From: Greg KH <gregkh@linuxfoundation.org>
To: Matthew Weber <matthew.weber@collins.com>
Cc: sashal@kernel.org, Sean Young <sean@mess.org>,
Mauro Carvalho Chehab <mchehab@s-opensource.com>,
Stefani Seibold <stefani@seibold.net>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kfifo: DECLARE_KIFO_PTR(fifo, u64) does not work on arm 32 bit
Date: Thu, 8 Jul 2021 17:36:49 +0200 [thread overview]
Message-ID: <YOcbkagxoPS2AreG@kroah.com> (raw)
In-Reply-To: <20210708152342.59635-1-matthew.weber@collins.com>
On Thu, Jul 08, 2021 at 10:23:41AM -0500, Matthew Weber wrote:
> From: Sean Young <sean@mess.org>
>
> If you try to store u64 in a kfifo (or a struct with u64 members),
> then the buf member of __STRUCT_KFIFO_PTR will cause 4 bytes
> padding due to alignment (note that struct __kfifo is 20 bytes
> on 32 bit).
>
> That in turn causes the __is_kfifo_ptr() to fail, which is caught
> by kfifo_alloc(), which now returns EINVAL.
>
> So, ensure that __is_kfifo_ptr() compares to the right structure.
>
> Signed-off-by: Sean Young <sean@mess.org>
> Acked-by: Stefani Seibold <stefani@seibold.net>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
> Signed-off-by: Matthew Weber <matthew.weber@collins.com>
> ---
>
> This patch originally made it into 4.16 as
> 8a866fee3909c49738e1c4429a8d2b9bf27e015d but is a bug on at least 4.14
> for any 32bit system(PPC/ARM/...) using kfifo with u64 datatypes.
>
> Please add to linux-4.14.y for the next LTS tag.
> (Below patch is a cherry-pick of the commit onto linux-4.14.y and was
> verified on 32bit hardware.)
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2021-07-08 15:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 15:23 [PATCH] kfifo: DECLARE_KIFO_PTR(fifo, u64) does not work on arm 32 bit Matthew Weber
2021-07-08 15:36 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOcbkagxoPS2AreG@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.weber@collins.com \
--cc=mchehab@kernel.org \
--cc=mchehab@s-opensource.com \
--cc=sashal@kernel.org \
--cc=sean@mess.org \
--cc=stefani@seibold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox