From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0FBEC07E99 for ; Fri, 9 Jul 2021 07:20:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B3F5961283 for ; Fri, 9 Jul 2021 07:20:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231147AbhGIHXT (ORCPT ); Fri, 9 Jul 2021 03:23:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230121AbhGIHXS (ORCPT ); Fri, 9 Jul 2021 03:23:18 -0400 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5455C0613E5 for ; Fri, 9 Jul 2021 00:20:35 -0700 (PDT) Received: by mail-pl1-x62f.google.com with SMTP id c15so4534840pls.13 for ; Fri, 09 Jul 2021 00:20:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wfVRDCn12PvjlI/4gGcypwOenkONM+SKIDRbqQICJ/w=; b=MExi26fU8r+DPQ3PGXA4FDAN7ifJLx45Gvgv9i5LYPl/+FZg0b/Tiebkbctj1AfWua VcV7+4INK5iSHWC1zl3aZ70cmFN0+kJBfUqNPEvoWi/VhMUZWabV+WaHm8kzAJ1xqvBu /W1TLeyxj79l6n1XLm/5ujeR4vwHnzqnRkw4E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wfVRDCn12PvjlI/4gGcypwOenkONM+SKIDRbqQICJ/w=; b=cqKA2G4LEHpG/q5p3xLEAAOunjVgmc34enyEtkivl08N6hsBcAXHfP3Sv6R4KPE7Sb Le0ZS8UM/+Gvd3kCY7Tj47sjDNP2XkulE3HKMntfiq2u9ZDQ3BiOEgKOD7PzCBK2I9k+ ONQSNGSMIn4d4q1hTxJaRiQmRMi7HxGJqTp9K/smsrTuxUDtowx/YFF3OW5kacSdJhKG 2xptCmU5FH2TNK1DTWxV8T9eeM8LHl7mBWLnDnCHOCCdWMhR80M11Viz9SD8DNOHqH+2 DY3d+kjsL2xLETzji4n6JB5bW6d2hwXI07eKQn36qJgxj5eg5W5JEbilj3JZF7cqZtHX SmZg== X-Gm-Message-State: AOAM5308EUlG18PTuVZ2+x/CHn/2qj9mJXWD8aK/ebqCl3iAygNKx5uO RTmJI8thwqOfsXfsnYjUYE+UnQ== X-Google-Smtp-Source: ABdhPJze9epknpvE6W/UqRj8DzBUd2K+lgb9x5VCG+ErVveN15EM76unXCMQ/WR6gtw5sqdRRsW8yA== X-Received: by 2002:a17:90a:a4c2:: with SMTP id l2mr2697048pjw.159.1625815235102; Fri, 09 Jul 2021 00:20:35 -0700 (PDT) Received: from google.com ([2409:10:2e40:5100:a30d:fc4:7834:ee08]) by smtp.gmail.com with ESMTPSA id b10sm5062208pfi.122.2021.07.09.00.20.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jul 2021 00:20:34 -0700 (PDT) Date: Fri, 9 Jul 2021 16:20:28 +0900 From: Sergey Senozhatsky To: Tomasz Figa Cc: Sergey Senozhatsky , Hans Verkuil , Ricardo Ribalda , Christoph Hellwig , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 8/8] videobuf2: handle non-contiguous DMA allocations Message-ID: References: <20210427131344.139443-1-senozhatsky@chromium.org> <20210427131344.139443-9-senozhatsky@chromium.org> <10a0903a-e295-5cba-683a-1eb89a0804ed@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (21/07/07 23:10), Tomasz Figa wrote: > > > > > > > > I guess this should address the case when > > > > > > > > "after allocating the buffer, the buffer is exported as a dma_buf and > > > > another device calls dma_buf_ops vb2_dc_dmabuf_ops_vmap, which in turn > > > > calls dma_buf_map_set_vaddr(map, buf->vaddr); with a NULL buf->vaddr" > > > > > > Sorry, I fail to get what this is about. Where does this quote come from? > > > > Bottom half of https://lore.kernel.org/lkml/10a0903a-e295-5cba-683a-1eb89a0804ed@xs4all.nl/ > > I see, thanks for the pointer. Yes, vb2_dc_dmabuf_ops_vmap() needs to > be changed so that it calls vb2_dc_vaddr() internally instead of > relying on buf->vaddr directly. Done.