From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alexander Gordeev <lasaine@lvk.cs.msu.su>
Cc: linux-kernel@vger.kernel.org, Rodolfo Giometti <giometti@enneenne.com>
Subject: Re: [PATCH v1 1/1] pps: generators: pps_gen_parport: Switch to use module_parport_driver()
Date: Mon, 12 Jul 2021 16:57:35 +0300 [thread overview]
Message-ID: <YOxKT9FnFPd+491W@smile.fi.intel.com> (raw)
In-Reply-To: <YMoOVrJ1ETVhRr4F@kroah.com>
On Wed, Jun 16, 2021 at 04:44:38PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jun 16, 2021 at 05:31:21PM +0300, Andy Shevchenko wrote:
> > Switch to use module_parport_driver() to reduce boilerplate code.
> > + pr_info("hrtimer avg error is %ldns\n", hrtimer_error);
>
> Why is this line needed? When drivers work properly, they are quiet.
>
> I know the existing code has it, no reason it needs to stay here, that's
> why we created these macros, to remove the ability for drivers to be
> printing junk like this that they do not need to be printing.
Seems the original authors keeps silent. What do you suggest in this case?
Remove the line and resubmit?
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-07-12 13:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 14:31 [PATCH v1 1/1] pps: generators: pps_gen_parport: Switch to use module_parport_driver() Andy Shevchenko
2021-06-16 14:44 ` Greg Kroah-Hartman
2021-06-16 14:57 ` Andy Shevchenko
2021-06-18 15:40 ` Alexander Gordeev
2021-07-12 13:57 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOxKT9FnFPd+491W@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=giometti@enneenne.com \
--cc=gregkh@linuxfoundation.org \
--cc=lasaine@lvk.cs.msu.su \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox