Re: [PATCH 3/3] m68k: leave stack mangling to asm wrapper of sigreturn()

Al Viro
2021-09-16T03:21:30Z

On Thu, Sep 16, 2021 at 12:53:53PM +1200, Michael Schmitz wrote:
> > You'd need to
> > * load the frame type from sigcontext (and deal with EFAULT, etc.)
> > * make decision based on that
> > * pass the type down into sigreturn(), so we wouldn't run into
> > mismatches.
> >
> > And all that just to avoid a single "subtract a constant from stack pointer"
> > insn. We are on a very shallow kernel stack here - it's a syscall entry,
> > after all. And the stack footprint of do_sigreturn() is fairly small - e.g.
> > stat(2) eats a lot more.
>
> Thanks, that's what I was wondering. Not worth the extra complexity then.
>
> >
> > We are not initializing the gap either - it's just reserved on stack; we only
> > access it if we need to enlarge the stack frame.
> >
> > IOW, what would be the benefit of trying to avoid unconditional gap there?
>
> Avoiding a kernel stack overflow - there are comments in the code that warn
> against that, but those may be largely historic...

This is syscall entry; moreover, it critically relies upon the fixed stack
layout - type 0 exception frame + pt_regs + switch_stack + (now) gap.
Followed by fairly shallow C call chain. I suspect that the deepest you
can get there is when you get an unmapped page when reading the sigframe
and go into page fault handling, with call chain going into some filesystem's
->readpage(). If it was that close to stack overflow, we'd see them all
the time in e.g. random net ioctl doing copy_from_user() - that's going
to be deeper. Or in stat(2), for that matter.