public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Andi Kleen <ak@linux.intel.com>, Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH 5/5] perf tools: Add pipe_test.sh to verify pipe operations
Date: Sun, 18 Jul 2021 23:38:48 +0200	[thread overview]
Message-ID: <YPSfaEIKydevKLpi@krava> (raw)
In-Reply-To: <20210714003442.1111502-6-namhyung@kernel.org>

On Tue, Jul 13, 2021 at 05:34:42PM -0700, Namhyung Kim wrote:

SNIP

> diff --git a/tools/perf/tests/shell/pipe_test.sh b/tools/perf/tests/shell/pipe_test.sh
> new file mode 100755
> index 000000000000..b6a89c6896c3
> --- /dev/null
> +++ b/tools/perf/tests/shell/pipe_test.sh
> @@ -0,0 +1,69 @@
> +#!/bin/sh
> +# perf pipe recording and injection test
> +# SPDX-License-Identifier: GPL-2.0
> +
> +# skip if there's no compiler
> +if ! [ -x "$(command -v cc)" ]; then
> +	echo "failed: no compiler, install gcc"
> +	exit 2
> +fi
> +
> +file=$(mktemp /tmp/test.file.XXXXXX)
> +data=$(mktemp /tmp/perf.data.XXXXXX)
> +
> +cat <<EOF | cc -o ${file} -x c -
> +#include <signal.h>
> +#include <stdlib.h>
> +#include <unistd.h>
> +
> +volatile int done;
> +
> +void sigalrm(int sig) {
> +	done = 1;
> +}
> +
> +__attribute__((noinline)) void noploop(void) {
> +	while (!done)
> +		continue;
> +}
> +
> +int main(int argc, char *argv[]) {
> +	int sec = 1;
> +
> +	if (argc > 1)
> +		sec = atoi(argv[1]);
> +
> +	signal(SIGALRM, sigalrm);
> +	alarm(sec);
> +
> +	noploop();
> +	return 0;
> +}
> +EOF
> +
> +
> +if ! perf record -e cycles:u -o - ${file} | perf report -i - --task | grep test.file; then

hi,
cycles:u will fail in virtual machine, could you use
cpu-clock instead or skip the test?

jirka

> +	echo "cannot find the test file in the perf report"
> +	exit 1
> +fi
> +
> +if ! perf record -e cycles:u -o - ${file} | perf inject -b | perf report -i - | grep noploop; then
> +	echo "cannot find noploop function in pipe #1"
> +	exit 1
> +fi
> +
> +perf record -e cycles:u -o - ${file} | perf inject -b -o ${data}
> +if ! perf report -i ${data} | grep noploop; then
> +	echo "cannot find noploop function in pipe #2"
> +	exit 1
> +fi
> +
> +perf record -e cycles:u -o ${data} ${file}
> +if ! perf inject -b -i ${data} | perf report -i - | grep noploop; then
> +	echo "cannot find noploop function in pipe #3"
> +	exit 1
> +fi
> +
> +
> +rm -f ${file} ${data} ${data}.old
> +exit 0
> -- 
> 2.32.0.93.g670b81a890-goog
> 


  reply	other threads:[~2021-07-18 21:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-14  0:34 [PATCHSET v2 0/5] perf inject: Fix broken data with mixed input/output Namhyung Kim
2021-07-14  0:34 ` [PATCH 1/5] perf tools: Remove repipe argument from perf_session__new() Namhyung Kim
2021-07-14  0:34 ` [PATCH 2/5] perf tools: Pass a fd to perf_file_header__read_pipe() Namhyung Kim
2021-07-14  0:34 ` [PATCH 3/5] perf inject: Fix output from a pipe to a file Namhyung Kim
2021-07-14  0:34 ` [PATCH 4/5] perf inject: Fix output from a file to a pipe Namhyung Kim
2021-07-14  0:34 ` [PATCH 5/5] perf tools: Add pipe_test.sh to verify pipe operations Namhyung Kim
2021-07-18 21:38   ` Jiri Olsa [this message]
2021-07-19 19:28     ` Namhyung Kim
  -- strict thread matches above, loose matches on Subject: below --
2021-07-19 22:31 [PATCHSET v3 0/5] perf inject: Fix broken data with mixed input/output Namhyung Kim
2021-07-19 22:31 ` [PATCH 5/5] perf tools: Add pipe_test.sh to verify pipe operations Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPSfaEIKydevKLpi@krava \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=irogers@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox