* linux-next: Fixes tag needs some work in the fpga tree
@ 2021-07-18 22:19 Stephen Rothwell
2021-07-18 22:48 ` Moritz Fischer
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2021-07-18 22:19 UTC (permalink / raw)
To: Moritz Fischer; +Cc: Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 408 bytes --]
Hi all,
In commit
6c17b7ff1d11 ("fpga: zynqmp-fpga: Address warning about unused variable")
Fixes tag
Fixes: c09f7471127e ("fpga manager: Adding FPGA Manager support for
has these problem(s):
- Subject has leading but no trailing parentheses
- Subject has leading but no trailing quotes
Please do not split Fixes tags over more than one line.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: linux-next: Fixes tag needs some work in the fpga tree
2021-07-18 22:19 linux-next: Fixes tag needs some work in the fpga tree Stephen Rothwell
@ 2021-07-18 22:48 ` Moritz Fischer
2021-07-19 6:21 ` Stephen Rothwell
0 siblings, 1 reply; 3+ messages in thread
From: Moritz Fischer @ 2021-07-18 22:48 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Moritz Fischer, Linux Kernel Mailing List,
Linux Next Mailing List
Hi Stephen,
On Mon, Jul 19, 2021 at 08:19:26AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 6c17b7ff1d11 ("fpga: zynqmp-fpga: Address warning about unused variable")
>
> Fixes tag
>
> Fixes: c09f7471127e ("fpga manager: Adding FPGA Manager support for
>
> has these problem(s):
>
> - Subject has leading but no trailing parentheses
> - Subject has leading but no trailing quotes
>
> Please do not split Fixes tags over more than one line.
>
> --
> Cheers,
> Stephen Rothwell
D'oh. Do people fix these things generally with a rebase?
- Moritz
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: linux-next: Fixes tag needs some work in the fpga tree
2021-07-18 22:48 ` Moritz Fischer
@ 2021-07-19 6:21 ` Stephen Rothwell
0 siblings, 0 replies; 3+ messages in thread
From: Stephen Rothwell @ 2021-07-19 6:21 UTC (permalink / raw)
To: Moritz Fischer; +Cc: Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 843 bytes --]
Hi Moritz,
On Sun, 18 Jul 2021 15:48:15 -0700 Moritz Fischer <mdf@kernel.org> wrote:
>
> On Mon, Jul 19, 2021 at 08:19:26AM +1000, Stephen Rothwell wrote:
> >
> > In commit
> >
> > 6c17b7ff1d11 ("fpga: zynqmp-fpga: Address warning about unused variable")
> >
> > Fixes tag
> >
> > Fixes: c09f7471127e ("fpga manager: Adding FPGA Manager support for
> >
> > has these problem(s):
> >
> > - Subject has leading but no trailing parentheses
> > - Subject has leading but no trailing quotes
> >
> > Please do not split Fixes tags over more than one line.
>
> D'oh. Do people fix these things generally with a rebase?
It varies among maintainers, but a rebase is the only way to fix it (if
that is what you want to do).
You could just take it as a lesson for the future.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-19 6:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-18 22:19 linux-next: Fixes tag needs some work in the fpga tree Stephen Rothwell
2021-07-18 22:48 ` Moritz Fischer
2021-07-19 6:21 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox