Re: [PATCH v14 5/9] staging: hi6421-spmi-pmic: cleanup drvdata

Greg Kroah-Hartman
2021-07-21T09:33:42Z

On Sat, Jul 17, 2021 at 11:58:16AM +0200, Mauro Carvalho Chehab wrote:
> There are lots of fields at struct hi6421_spmi_pmic that aren't
> used. In a matter of fact, only regmap is needed.
>
> So, drop the struct as a hole, and set just the regmap as
> the drvdata.
>
> While here, add a missing dot at the Huawei's copyrights.
>
> Acked-by: Mark Brown <broonie@kernel.org>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
> drivers/misc/hi6421v600-irq.c | 9 ++++----
> drivers/regulator/hi6421v600-regulator.c | 10 ++++-----
> drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 16 +++++--------
> include/linux/mfd/hi6421-spmi-pmic.h | 25 ---------------------
> 4 files changed, 14 insertions(+), 46 deletions(-)
> delete mode 100644 include/linux/mfd/hi6421-spmi-pmic.h

This patch fails to apply to my 5.14-rc2 tree, it gets a failure in the
regulator portion of the patch.

thanks,

greg k-h