Re: [PATCH V6 2/2] dt-bindings: pinctrl: qcom-pmic-gpio: Remove the interrupts property

Bjorn Andersson
2021-07-19T18:24:41Z

On Mon 19 Jul 06:07 CDT 2021, satya priya wrote:

> Remove the interrupts property as we no longer specify it.
>
> Signed-off-by: satya priya <skakit@codeaurora.org>
> Acked-by: Rob Herring <robh@kernel.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Regards,
Bjorn

> ---
> Changes in V5:
> - This is newly added in V5.As per Bjorn's comments on [1]
> removed the interrupts property as it is no longer used.
>
> [1] https://lore.kernel.org/patchwork/patch/1434144/
>
> Changes in V6:
> - No changes.
>
> .../bindings/pinctrl/qcom,pmic-gpio.yaml | 28 ++++------------------
> 1 file changed, 4 insertions(+), 24 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> index 7a0d2d8..9bd01db 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> @@ -56,18 +56,11 @@ properties:
> reg:
> maxItems: 1
>
> - interrupts:
> - minItems: 1
> - maxItems: 44
> - description:
> - Must contain an array of encoded interrupt specifiers for
> - each available GPIO
> + interrupt-controller: true
>
> '#interrupt-cells':
> const: 2
>
> - interrupt-controller: true
> -
> gpio-controller: true
>
> gpio-ranges:
> @@ -87,6 +80,7 @@ required:
> - gpio-controller
> - '#gpio-cells'
> - gpio-ranges
> + - interrupt-controller
>
> patternProperties:
> '-state$':
> @@ -223,22 +217,8 @@ examples:
> pm8921_gpio: gpio@150 {
> compatible = "qcom,pm8921-gpio", "qcom,ssbi-gpio";
> reg = <0x150 0x160>;
> - interrupts = <192 1>, <193 1>, <194 1>,
> - <195 1>, <196 1>, <197 1>,
> - <198 1>, <199 1>, <200 1>,
> - <201 1>, <202 1>, <203 1>,
> - <204 1>, <205 1>, <206 1>,
> - <207 1>, <208 1>, <209 1>,
> - <210 1>, <211 1>, <212 1>,
> - <213 1>, <214 1>, <215 1>,
> - <216 1>, <217 1>, <218 1>,
> - <219 1>, <220 1>, <221 1>,
> - <222 1>, <223 1>, <224 1>,
> - <225 1>, <226 1>, <227 1>,
> - <228 1>, <229 1>, <230 1>,
> - <231 1>, <232 1>, <233 1>,
> - <234 1>, <235 1>;
> -
> + interrupt-controller;
> + #interrupt-cells = <2>;
> gpio-controller;
> gpio-ranges = <&pm8921_gpio 0 0 44>;
> #gpio-cells = <2>;
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>