From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F146C07E9B for ; Wed, 21 Jul 2021 10:37:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6416E61029 for ; Wed, 21 Jul 2021 10:37:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238495AbhGUJzu (ORCPT ); Wed, 21 Jul 2021 05:55:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:54800 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237923AbhGUJnX (ORCPT ); Wed, 21 Jul 2021 05:43:23 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 40C75610F7; Wed, 21 Jul 2021 10:23:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626863039; bh=Iu2JiDDG0eWSlcpAlkHVXAWB7CncVs3Oinc1pECdzf4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PB/4TrgteWCs+wehP3yxy4taysJjkpy9Oo/hsMHiBa2pGxht5vcZJa402TTcMsEOd s5tvhazFM3zgRQ8LDP5J9RTXLGM1HZOQOm1Ffc+i/hWfVcsKOwcJwXVsJLES+Qm2VG OzUXfWSYC3mPthvWehXlqBOKNNIvbIHdVWGD90vE= Date: Wed, 21 Jul 2021 12:23:57 +0200 From: Greg KH To: Zhenguo Zhao Cc: jirislaby@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] tty: n_gsm: delete SABM command frame as requester Message-ID: References: <1625138840-22974-1-git-send-email-zhenguo6858@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1625138840-22974-1-git-send-email-zhenguo6858@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 01, 2021 at 07:27:20PM +0800, Zhenguo Zhao wrote: > From: Zhenguo Zhao > > as initiator,it need to send SABM command ,as requester,there is > no need to send the SABM control frame,it will cause redundant data. Same issue here with this text. Please work on fixing it up to be understood by others better. > > Signed-off-by: Zhenguo Zhao > --- > drivers/tty/n_gsm.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c > index 5fea02c..41a6501 100644 > --- a/drivers/tty/n_gsm.c > +++ b/drivers/tty/n_gsm.c > @@ -2997,6 +2997,7 @@ static int gsmtty_open(struct tty_struct *tty, struct file *filp) > { > struct gsm_dlci *dlci = tty->driver_data; > struct tty_port *port = &dlci->port; > + struct gsm_mux *gsm = dlci->gsm; > > port->count++; > tty_port_tty_set(port, tty); > @@ -3005,8 +3006,9 @@ static int gsmtty_open(struct tty_struct *tty, struct file *filp) > /* We could in theory open and close before we wait - eg if we get > a DM straight back. This is ok as that will have caused a hangup */ > tty_port_set_initialized(port, 1); > - /* Start sending off SABM messages */ > - gsm_dlci_begin_open(dlci); > + /* Start sending off SABM messages for initiator */ > + if (gsm->initiator) > + gsm_dlci_begin_open(dlci); Why is this only an issue for initiators? And why has no one reported this problem before now? Do you not also need to make ths same change somewhere else when shutting down? thanks, greg k-h