From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA003C6377A for ; Wed, 21 Jul 2021 08:20:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B87A461248 for ; Wed, 21 Jul 2021 08:20:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236858AbhGUHkM (ORCPT ); Wed, 21 Jul 2021 03:40:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:45294 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236493AbhGUHgP (ORCPT ); Wed, 21 Jul 2021 03:36:15 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 87FFF6120D; Wed, 21 Jul 2021 08:16:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626855377; bh=6+TOhw2bw1BErXR+/AP1jMtlMViQ/etkLZyn7PR6csY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oROQtlPdkDslk10LEvycJsRH/pHLR6KF47YQ0tn+TCHcaZ1hX2VtSAQCv873QqLka 21od/8shiDxJum85nuKq2GxjjZ/IqUtz6LPECZ4+CSwYiWuhqED5++APwyxLufBOAK k2HQyf5St3a0sEcdGHptTuAfm0xsaPkyrbC1v1Q4= Date: Wed, 21 Jul 2021 10:16:14 +0200 From: Greg KH To: Phillip Potter Cc: Larry.Finger@lwfinger.net, dan.carpenter@oracle.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH resend] staging: rtl8188eu: move all source files from core subdirectory Message-ID: References: <20210719224601.255364-1-phil@philpotter.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210719224601.255364-1-phil@philpotter.co.uk> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 19, 2021 at 11:46:01PM +0100, Phillip Potter wrote: > Move all C source files from the core subdirectory to the root > folder of the driver, and adjust Makefile accordingly. The ultmate > goal is to remove hal layer and fold its functionalty into the main > sources. At this point, the distinction between hal and core will be > meaningless, so this is the first step towards simplifying the file > layout. > > Signed-off-by: Phillip Potter > --- > drivers/staging/rtl8188eu/Makefile | 34 +++++++++---------- > drivers/staging/rtl8188eu/{core => }/rtw_ap.c | 0 As others have pointed out, let's move files when they need to be moved, not yet. Removing the HAL layer is great here, but when that happens, the hal/ directory will be empty and we can go from there if things still need to be moved. thanks, greg k-h