From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F4F1C636CE for ; Wed, 21 Jul 2021 09:33:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 063006120C for ; Wed, 21 Jul 2021 09:33:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237611AbhGUIwp (ORCPT ); Wed, 21 Jul 2021 04:52:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:60938 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237977AbhGUIpO (ORCPT ); Wed, 21 Jul 2021 04:45:14 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E87DF60231; Wed, 21 Jul 2021 09:25:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626859549; bh=yOJ5z3dKNV3+QchjXIKT3u7IgTGFQKf/v3HEvGwojAg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MFNEJy6+0KDma+GVnPxoqHG/SyR6bZYdr9N5GCoasKKLZ+3ZRPnrhd7YAq4qBl9dj yA2/lEXl51QkqvB9u9xzEv/IWu1qDifBaCmFAyodadwkTn9nTK9WabCUlfoC4ae/ua MGg6tEJI1ZgD931V/EOFH/GTajj7ZchxM5NWUdpM= Date: Wed, 21 Jul 2021 11:25:47 +0200 From: Greg Kroah-Hartman To: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Arnd Bergmann , Lee Jones , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH v14 5/9] staging: hi6421-spmi-pmic: cleanup drvdata Message-ID: References: <723edefbb2e9ce0b70d9c7bce95f288e3ea1f5b1.1626515862.git.mchehab+huawei@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <723edefbb2e9ce0b70d9c7bce95f288e3ea1f5b1.1626515862.git.mchehab+huawei@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 17, 2021 at 11:58:16AM +0200, Mauro Carvalho Chehab wrote: > There are lots of fields at struct hi6421_spmi_pmic that aren't > used. In a matter of fact, only regmap is needed. > > So, drop the struct as a hole, and set just the regmap as > the drvdata. > > While here, add a missing dot at the Huawei's copyrights. > > Acked-by: Mark Brown > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/misc/hi6421v600-irq.c | 9 ++++---- > drivers/regulator/hi6421v600-regulator.c | 10 ++++----- > drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 16 +++++-------- > include/linux/mfd/hi6421-spmi-pmic.h | 25 --------------------- > 4 files changed, 14 insertions(+), 46 deletions(-) > delete mode 100644 include/linux/mfd/hi6421-spmi-pmic.h This patch fails to apply to my 5.14-rc2 tree, it gets a failure in the regulator portion of the patch. thanks, greg k-h