public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Cc: Tejun Heo <tj@kernel.org>,
	linux-kernel@vger.kernel.org, yuanxzhang@fudan.edu.cn,
	Xin Tan <tanxin.ctf@gmail.com>
Subject: Re: [PATCH] kernfs: Convert from atomic_t to refcount_t on kernfs_node->count
Date: Wed, 21 Jul 2021 17:36:20 +0200	[thread overview]
Message-ID: <YPg+9MGnEOxj9PB3@kroah.com> (raw)
In-Reply-To: <1626683601-64278-1-git-send-email-xiyuyang19@fudan.edu.cn>

On Mon, Jul 19, 2021 at 04:33:21PM +0800, Xiyu Yang wrote:
> refcount_t type and corresponding API can protect refcounters from
> accidental underflow and overflow and further use-after-free situations.

But this really is a count, not a refcount.

So are you _sure_ this should be changed?

What did you to do to test this?

thanks,

greg k-h

       reply	other threads:[~2021-07-21 15:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1626683601-64278-1-git-send-email-xiyuyang19@fudan.edu.cn>
2021-07-21 15:36 ` Greg Kroah-Hartman [this message]
     [not found] <60f8506d.1c69fb81.d8d4d.3bceSMTPIN_ADDED_BROKEN@mx.google.com>
2021-07-22  5:49 ` [PATCH] kernfs: Convert from atomic_t to refcount_t on kernfs_node->count Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPg+9MGnEOxj9PB3@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tanxin.ctf@gmail.com \
    --cc=tj@kernel.org \
    --cc=xiyuyang19@fudan.edu.cn \
    --cc=yuanxzhang@fudan.edu.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox