From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CFEBC636C9 for ; Wed, 21 Jul 2021 15:19:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F1796124C for ; Wed, 21 Jul 2021 15:19:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239785AbhGUOib (ORCPT ); Wed, 21 Jul 2021 10:38:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:33488 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238083AbhGUOiZ (ORCPT ); Wed, 21 Jul 2021 10:38:25 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2D9D861245; Wed, 21 Jul 2021 15:19:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626880742; bh=iyJmmnRrmq3NjJ0o9+o2VxFl1R0JWz/x6crIEc3pGdc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bztUAqqMxqi/SzVRjgbhD2sJ8CieKxas0xnNwFaILxOp3EoCBq3Waf/Va5tII0mwJ 4wdTIg4KizMLZcLI/V38eZAAgf7a8gxfkS8ScDn5xK5w0XGb3f9qtGahOTvZ7d4Bk4 cVrnyNhrO9KsGeSo4aoMC+Q3PN2E19SIWeC6YO/bkFflFZgjpgu1xKzo545Vg5+hc2 2yhnpji+iBW9SIO9Vc5GQ/FNNS5C2/+l8hUhBbp4D23zSZGkPDzQs5/BLbBvJd9mrb zUJ987dbD9oYOQFoS5FSU0Ivex0N53tYBs0cJV09Euxnsh19p7ENC96XMFMLzj+Jeo jRKH1gb/918nw== Date: Wed, 21 Jul 2021 11:19:01 -0400 From: Sasha Levin To: Steven Rostedt Cc: Pavel Machek , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable@vger.kernel.org, David Wysochanski , Chuck Lever , "J. Bruce Fields" Subject: Re: [PATCH 5.10 147/243] NFSD: Fix TP_printk() format specifier in nfsd_clid_class Message-ID: References: <20210719144940.904087935@linuxfoundation.org> <20210719144945.657682587@linuxfoundation.org> <20210720214847.GB704@amd> <20210721100413.227fd0cb@oasis.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20210721100413.227fd0cb@oasis.local.home> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 21, 2021 at 10:04:13AM -0400, Steven Rostedt wrote: >On Tue, 20 Jul 2021 23:48:47 +0200 >Pavel Machek wrote: > >> Hi! >> >> > [ Upstream commit a948b1142cae66785521a389cab2cce74069b547 ] >> > >> > Since commit 9a6944fee68e ("tracing: Add a verifier to check string >> > pointers for trace events"), which was merged in v5.13-rc1, >> > TP_printk() no longer tacitly supports the "%.*s" format specifier. >> > >> > These are low value tracepoints, so just remove them. >> >> So I understand we want this for mainline, but AFAICT 5.10 does not >> have 9a6944fee68e ("tracing: Add a verifier to check string pointers >> for trace events") commit, so this does not fix any bug and removal of >> tracepoints can be surprising. >> > >Thanks for pointing this out. I get so many stable patches, I don't >have time to look at all of them. > >Greg, I don't think this should be backported. The verifier code had a >bug in it that broke the '%.*s' formats. This patch removed the good >code because of the broken code. > >See eb01f5353bdaa ("tracing: Handle %.*s in trace_check_vprintf()") Uh, yes, I'll drop it. Thanks for catching this! -- Thanks, Sasha