From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Xiyu Yang <19210240158@fudan.edu.cn>
Cc: Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org, yuanxzhang@fudan.edu.cn,
Xin Tan <tanxin.ctf@gmail.com>
Subject: Re: Re: [PATCH] kernfs: Convert from atomic_t to refcount_t on kernfs_node->count
Date: Thu, 22 Jul 2021 10:32:23 +0200 [thread overview]
Message-ID: <YPktF6NKg9DvKfnH@kroah.com> (raw)
In-Reply-To: <57e48621.5aed.17accfa0d36.Coremail.19210240158@fudan.edu.cn>
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Thu, Jul 22, 2021 at 02:49:37PM +0800, Xiyu Yang wrote:
> Hi Greg,
>
> I consider it as a reference count due to its related operations and
> the developer's comments, such as "put a reference count on a
> kernfs_node" around the kernfs_put(). If anything wrong, please let me
> know.
Did you test this? Is this really a reference count when looking at the
code? Or is it just a counter that we use for dealing with vfs issues?
Usually filesystems and the vfs can not use the refcount_t type for
various reasons, please do some research on that before making these
changes.
And of course, please explain how you tested this patch if you resubmit
it with the needed information.
thanks,
greg k-h
prev parent reply other threads:[~2021-07-22 8:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <60f8506d.1c69fb81.d8d4d.3bceSMTPIN_ADDED_BROKEN@mx.google.com>
2021-07-22 5:49 ` [PATCH] kernfs: Convert from atomic_t to refcount_t on kernfs_node->count Greg Kroah-Hartman
2021-07-22 6:25 ` Xiyu Yang
2021-07-22 6:32 ` Greg Kroah-Hartman
2021-07-22 6:49 ` Xiyu Yang
2021-07-22 8:32 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPktF6NKg9DvKfnH@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=19210240158@fudan.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=tanxin.ctf@gmail.com \
--cc=tj@kernel.org \
--cc=yuanxzhang@fudan.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox