From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jiri Slaby <jirislaby@kernel.org>, Dennis Giaya <dgiaya@whoi.edu>
Subject: Re: [PATCH v1 1/1] serial: max310x: Use clock-names property matching to recognize XTAL
Date: Thu, 22 Jul 2021 18:45:40 +0300 [thread overview]
Message-ID: <YPmSpNZr/yQiPqsO@smile.fi.intel.com> (raw)
In-Reply-To: <20210722150233.30897-1-andriy.shevchenko@linux.intel.com>
On Thu, Jul 22, 2021 at 06:02:33PM +0300, Andy Shevchenko wrote:
> Dennis reported that on ACPI-based systems the clock frequency
> isn't enough to configure device properly. We have to respect
> the clock source as well. To achieve this match the clock-names
> property against "xtal" to recognize crystal connection.
Dennis, please test this.
...
> - s->clk = devm_clk_get_optional(dev, "osc");
> + xtal = device_property_match_string(dev, "clock-names", "xtal") >= 0;
Meanwhile I will change this (not affects the testing in your case) to actually
negative one as:
..., "osc") < 0;
to be compatible with the original flow (in case there are two clock names, the
"osc" has a priority).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-07-22 15:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 15:02 [PATCH v1 1/1] serial: max310x: Use clock-names property matching to recognize XTAL Andy Shevchenko
2021-07-22 15:45 ` Andy Shevchenko [this message]
2021-07-22 21:05 ` Dennis Giaya
2021-07-23 12:28 ` andriy.shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPmSpNZr/yQiPqsO@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dgiaya@whoi.edu \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox