Re: [PATCH 13/13] media: ipu3-cio2: Add INT347A to cio2-bridge

Daniel Scally
2021-07-22T23:07:24Z

Hi Andy

On 22/07/2021 23:22, Andy Shevchenko wrote:
>
>
> On Thursday, July 22, 2021, Daniel Scally <djrscally@gmail.com
> <mailto:djrscally@gmail.com>> wrote:
>
> ACPI _HID INT347A represents the OV8865 sensor, the driver for
> which can
> support the platforms that the cio2-bridge serves. Add it to the array
> of supported sensors so the bridge will connect the sensor to the CIO2
> device.
>
> Signed-off-by: Daniel Scally <djrscally@gmail.com
> <mailto:djrscally@gmail.com>>
> ---
>  drivers/media/pci/intel/ipu3/cio2-bridge.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/pci/intel/ipu3/cio2-bridge.c
> b/drivers/media/pci/intel/ipu3/cio2-bridge.c
> index 4657e99df033..6195abd7582c 100644
> --- a/drivers/media/pci/intel/ipu3/cio2-bridge.c
> +++ b/drivers/media/pci/intel/ipu3/cio2-bridge.c
> @@ -24,6 +24,8 @@ static const struct cio2_sensor_config
> cio2_supported_sensors[] = {
>         CIO2_SENSOR_CONFIG("INT33BE", 0),
>         /* Omnivision OV2680 */
>         CIO2_SENSOR_CONFIG("OVTI2680", 0),
> +       /* Omnivision OV8865 */
> +       CIO2_SENSOR_CONFIG("INT347A", 1, 360000000),
>
>
> I assume it may be positioned at any index in the array. I prefer to
> see them sorted by HID

Yeah any position's fine; I seem to struggle with alphabetisation for
some reason :) No problem, I'll order them properly in v2.

>
>
>
>
>  };
>
>  static const struct cio2_property_names prop_names = {
> --
> 2.25.1
>
>
>
> --
> With Best Regards,
> Andy Shevchenko
>
>