Re: [PATCH v9 03/12] mfd: simple-mfd-i2c: Save the register client data

Mark Brown
2021-08-06T11:46:00Z

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

On Fri, Aug 06, 2021 at 12:38:36PM +0100, Lee Jones wrote:
> On Fri, 06 Aug 2021, Alistair Francis wrote:

> > + i2c_set_clientdata(i2c, regmap);
> > +

> No need to store this here.

> Just do this in the child device:

> dev_get_regmap(pdev->dev.parent, NULL);

Note that dev_get_regmap() is relatively expensive compared to a simple
driver data reference since it needs to go search for the device to find
the regmap, it's not the end of the world especially in the context of
doing I2C I/O but storing it isn't a terrible idea.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]