Re: [PATCH net-next 0/4] net: ipa: kill IPA_VALIDATION

Leon Romanovsky
2021-07-27T14:04:20Z

On Tue, Jul 27, 2021 at 08:40:42AM -0500, Alex Elder wrote:
> On 7/27/21 7:56 AM, Leon Romanovsky wrote:
> > > In any case I take your point. I will now add to my task list
> > > a review of these spots. I'd like to be sure an error message
> > > *is* reported at an appropriate level up the chain of callers so
> > > I can always identify the culprit in the a WARN_ON() fires (even
> > > though it should never
> > > happen). And in each case I'll evaluate
> > > whether returning is better than not.
> > You can, but users don't :). So if it is valid but error flow, that
> > needs user awareness, simply print something to the dmesg with *_err()
> > prints.
>
> For some reason you seem to care about users.

Yeah, this is my Achilles heel :)

Thanks