From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Fei Li <fei1.li@intel.com>
Cc: linux-kernel@vger.kernel.org, Shuo Liu <shuo.a.liu@intel.com>,
Reinette Chatre <reinette.chatre@intel.com>,
Zhi Wang <zhi.a.wang@intel.com>,
yu1.wang@intel.com
Subject: Re: [PATCH] virt: acrn: Do hcall_destroy_vm() before resource release
Date: Tue, 27 Jul 2021 16:47:58 +0200 [thread overview]
Message-ID: <YQAcnpQcO8h8/l8V@kroah.com> (raw)
In-Reply-To: <20210722062736.15050-1-fei1.li@intel.com>
On Thu, Jul 22, 2021 at 02:27:36PM +0800, Fei Li wrote:
> From: Shuo Liu <shuo.a.liu@intel.com>
>
> The ACRN hypervisor has scenarios which could run a real-time guest VM.
> The real-time guest VM occupies dedicated CPU cores, be assigned with
> dedicated PCI devices. It can run without the Service VM after boot up.
> hcall_destroy_vm() returns failure when a real-time guest VM refuses.
> The clearing of flag ACRN_VM_FLAG_DESTROYED causes some kernel resource
> double-freed in a later acrn_vm_destroy().
>
> Do hcall_destroy_vm() before resource release to drop this chance to
> destroy the VM if hypercall fails.
>
> Fixes: 9c5137aedd11 ("virt: acrn: Introduce VM management interfaces")
> Signed-off-by: Shuo Liu <shuo.a.liu@intel.com>
> Signed-off-by: Fei Li <fei1.li@intel.com>
> ---
Do you also want this backported to older kernels? If so, you need to
put a cc: stable in here, right? I'll go add it myself, but be more
careful next time please.
greg k-h
next prev parent reply other threads:[~2021-07-27 14:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 6:27 [PATCH] virt: acrn: Do hcall_destroy_vm() before resource release Fei Li
2021-07-27 14:47 ` Greg Kroah-Hartman [this message]
2021-07-29 3:22 ` Li Fei1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQAcnpQcO8h8/l8V@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=fei1.li@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=shuo.a.liu@intel.com \
--cc=yu1.wang@intel.com \
--cc=zhi.a.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox