From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: core: Fix incorrect type in assignment
Date: Wed, 28 Jul 2021 07:44:31 +0200 [thread overview]
Message-ID: <YQDuv2fIKtga0Blz@kroah.com> (raw)
In-Reply-To: <20210728004223.15102-1-fmdefrancesco@gmail.com>
On Wed, Jul 28, 2021 at 02:42:23AM +0200, Fabio M. De Francesco wrote:
> Fix sparse warning: incorrect type in assignment (different base types).
>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_security.c | 31 +++++++++++--------
> 1 file changed, 18 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c
> index a99f439328f1..527f710c7658 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_security.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_security.c
> @@ -35,8 +35,10 @@ const char *security_type_str(u8 value)
> */
> void rtw_wep_encrypt(struct adapter *padapter, u8 *pxmitframe)
> { /* exclude ICV */
> -
> - unsigned char crc[4];
> + union {
> + __le32 f0;
> + unsigned char f1[4];
> + } crc;
Odd indentation, are you sure this is right?
Please indent the fields by one more tab.
thanks,
greg k-h
prev parent reply other threads:[~2021-07-28 5:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 0:42 [PATCH] staging: rtl8723bs: core: Fix incorrect type in assignment Fabio M. De Francesco
2021-07-28 5:44 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQDuv2fIKtga0Blz@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=fmdefrancesco@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox