From: Andrew Lunn <andrew@lunn.ch>
To: Peter Geis <pgwipeout@gmail.com>
Cc: Michael Riesch <michael.riesch@wolfvision.net>,
devicetree@vger.kernel.org,
arm-mail-list <linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>, Liang Chen <cl@rock-chips.com>,
Simon Xue <xxm@rock-chips.com>
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: rk3568-evb1-v10: add ethernet support
Date: Wed, 28 Jul 2021 22:37:50 +0200 [thread overview]
Message-ID: <YQHAHmMmysBVpF+m@lunn.ch> (raw)
In-Reply-To: <CAMdYzYo8zf0wjtAxTuYQnZQsBtw38prNuAA0j0sBEamcbzZbfA@mail.gmail.com>
> Generally all rockchip boards use this value instead of the rgmii_id,
> I imagine because it's more consistent to tune here than the hit or
> miss support of the phy drivers.
Most PHY drivers actually implement it correctly, since by default,
most systems get the PHY to do the delays.
But if most Rockchip boards do it this way, there is a lot to be said
for consistence, so this is fine by me.
Andrew
next prev parent reply other threads:[~2021-07-28 20:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 16:10 [PATCH 0/2] add ethernet support to rk3568 dts Michael Riesch
2021-07-28 16:10 ` [PATCH 1/2] arm64: dts: rockchip: add gmac0 node to rk3568 Michael Riesch
2021-07-28 16:43 ` Heiko Stübner
2021-07-28 17:34 ` Heiko Stübner
2021-07-28 16:10 ` [PATCH 2/2] arm64: dts: rockchip: rk3568-evb1-v10: add ethernet support Michael Riesch
2021-07-28 16:45 ` Johan Jonker
2021-07-28 17:55 ` Andrew Lunn
2021-07-28 18:29 ` Peter Geis
2021-07-28 20:37 ` Andrew Lunn [this message]
2021-07-29 9:07 ` Michael Riesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQHAHmMmysBVpF+m@lunn.ch \
--to=andrew@lunn.ch \
--cc=cl@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael.riesch@wolfvision.net \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
--cc=xxm@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox