From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0CD8C43214 for ; Thu, 29 Jul 2021 05:54:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D5BB561055 for ; Thu, 29 Jul 2021 05:54:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234164AbhG2Fyc (ORCPT ); Thu, 29 Jul 2021 01:54:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:59376 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230223AbhG2Fyb (ORCPT ); Thu, 29 Jul 2021 01:54:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3D67A61053; Thu, 29 Jul 2021 05:54:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627538068; bh=rAXscKZrW+2+4LGOnZPqFBsItZBqoTEh6dVWtmRtH2s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ppnf4cw4XG1iifQPDU9vTPsziBWEDfVakd1QzjJc7424WDvwxsarkQXBOSne6lZRX 2LQTRfGte1ePbPnsuRNFBOPAGjCLDiW4aH1lspDeN3kcY1w1XQsvo64fyIaE7AJJzN hwQs8Gu2qqMdH6i2S4aDJtFdcovWFMFhZeSx/Iw0= Date: Thu, 29 Jul 2021 07:54:23 +0200 From: Greg KH To: Ian Pilcher Cc: linux-block@vger.kernel.org, linux-leds@vger.kernel.org, axboe@kernel.dk, linux-kernel@vger.kernel.org, pavel@ucw.cz, kernelnewbies@kernelnewbies.org Subject: Re: [RFC PATCH 4/8] block: Add block class attributes to manage LED trigger list Message-ID: References: <20210729015344.3366750-1-arequipeno@gmail.com> <20210729015344.3366750-5-arequipeno@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210729015344.3366750-5-arequipeno@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 28, 2021 at 08:53:40PM -0500, Ian Pilcher wrote: > * New class attributes - /sys/class/block/led_trigger_{new,list,del} > > * Add init function - blk_ledtrig_init() - to create the attributes > in sysfs. Call blk_ledtrig_init() from genhd_device_init() (in > block/genhd.c). > > * New file - block/blk-ledtrig.h That is an odd way to write a changelog, please read the documentation file about how to write a good changelog. thanks, greg k-h