From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EE35C432BE for ; Fri, 30 Jul 2021 22:19:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 83119610A6 for ; Fri, 30 Jul 2021 22:19:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234061AbhG3WTr (ORCPT ); Fri, 30 Jul 2021 18:19:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:51902 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232680AbhG3WTE (ORCPT ); Fri, 30 Jul 2021 18:19:04 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F302A610A6; Fri, 30 Jul 2021 22:18:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627683539; bh=gIRZmLSHg2oCuCzzrUdAVmZR964QJKWRL7lSRznz+70=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c+D/i0H9E9aW7yh91QtXvqeP2ApTvE2MS8e1tb15PTb0AlrYv3fi+CEz4OluJl4kb Ntd6VtQQ8k1Ez74u/XilPdo6nC7ZZ6MqfurtqzLiGml5N5UOvTjCe086I9B6BrmYaz WRtEWqwsYUvvVc2aQVbippDp/SWHSodBI+VYBUHURmnnTJBk9BPBSyM66sr3lrRHff ZuTVnsOuPXb4xApJTJQhOMtXjI2Ai4f5oE34B4/VpM2Wywwz/77vlyc67EUJ8AkGrT /kqy3L6M6B0gZcGe8W8AwAZWQfyiv1N4/+ruVFabY/IAUvVXUo3xtev3eManj0XwcO dR/VUQZ0pkKPQ== Date: Fri, 30 Jul 2021 15:18:57 -0700 From: Jaegeuk Kim To: Chao Yu Cc: Yangtao Li , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH] f2fs: reset free segment to prefree status when do_checkpoint() fail Message-ID: References: <20210427082106.2755-1-frank.li@vivo.com> <12ae52df-bc5e-82c3-4f78-1eafe7723f93@huawei.com> <5f37995c-2390-e8ca-d002-3639ad39e0d3@kernel.org> <8d2e3a63-72f9-bcb2-24e5-dddd84136001@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8d2e3a63-72f9-bcb2-24e5-dddd84136001@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/20, Chao Yu wrote: > On 2021/7/20 2:25, Jaegeuk Kim wrote: > > On 07/19, Chao Yu wrote: > > > On 2021/4/27 20:37, Chao Yu wrote: > > > > I think just reverting dirty/free bitmap is not enough if checkpoint fails, > > > > due to we have updated sbi->cur_cp_pack and nat/sit bitmap, next CP tries > > > > to overwrite last valid meta/node/data, then filesystem will be corrupted. > > > > > > > > So I suggest to set cp_error if do_checkpoint() fails until we can handle > > > > all cases, which is not so easy. > > > > > > > > How do you think? > > > > > > Let's add below patch first before you figure out the patch which covers all > > > things. > > > > > > From 3af957c98e9e04259f8bb93ca0b74ba164f3f27e Mon Sep 17 00:00:00 2001 > > > From: Chao Yu > > > Date: Mon, 19 Jul 2021 16:37:44 +0800 > > > Subject: [PATCH] f2fs: fix to stop filesystem update once CP failed > > > > > > During f2fs_write_checkpoint(), once we failed in > > > f2fs_flush_nat_entries() or do_checkpoint(), metadata of filesystem > > > such as prefree bitmap, nat/sit version bitmap won't be recovered, > > > it may cause f2fs image to be inconsistent, let's just set CP error > > > flag to avoid further updates until we figure out a scheme to rollback > > > all metadatas in such condition. > > > > > > Reported-by: Yangtao Li > > > Signed-off-by: Yangtao Li > > > Signed-off-by: Chao Yu > > > --- > > > fs/f2fs/checkpoint.c | 10 +++++++--- > > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > > > diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c > > > index 6c208108d69c..096c85022f62 100644 > > > --- a/fs/f2fs/checkpoint.c > > > +++ b/fs/f2fs/checkpoint.c > > > @@ -1639,8 +1639,10 @@ int f2fs_write_checkpoint(struct f2fs_sb_info *sbi, struct cp_control *cpc) > > > > > > /* write cached NAT/SIT entries to NAT/SIT area */ > > > err = f2fs_flush_nat_entries(sbi, cpc); > > > - if (err) > > > + if (err) { > > > + f2fs_stop_checkpoint(sbi, false); > > > > I think we should abuse this, since we can get any known ENOMEM as well. > > Yup, but one critical issue here is it can break A/B update of NAT area, > so, in order to fix this hole, how about using NOFAIL memory allocation > in f2fs_flush_nat_entries() first until we figure out the finial scheme? NOFAIL is risky, so how about adding a retry logic on ENOMEM with a message and then giving up if we can't get the memory? BTW, what about EIO or other family? > > Thanks, > > > > > > goto stop; > > > + } > > > > > > f2fs_flush_sit_entries(sbi, cpc); > > > > > > @@ -1648,10 +1650,12 @@ int f2fs_write_checkpoint(struct f2fs_sb_info *sbi, struct cp_control *cpc) > > > f2fs_save_inmem_curseg(sbi); > > > > > > err = do_checkpoint(sbi, cpc); > > > - if (err) > > > + if (err) { > > > + f2fs_stop_checkpoint(sbi, false); > > > f2fs_release_discard_addrs(sbi); > > > - else > > > + } else { > > > f2fs_clear_prefree_segments(sbi, cpc); > > > + } > > > > > > f2fs_restore_inmem_curseg(sbi); > > > stop: > > > -- > > > 2.22.1