From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Dongliang Mu <mudongliangabcd@gmail.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Ard Biesheuvel <ardb@kernel.org>,
Xiang Chen <chenxiang66@hisilicon.com>,
Eric Biggers <ebiggers@google.com>,
Colin Ian King <colin.king@canonical.com>,
linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] crypto: sun8i-ss: fix multiple memory leaks in sun8i_ss_hash_run
Date: Mon, 2 Aug 2021 20:27:06 +0200 [thread overview]
Message-ID: <YQg4+skrb9dxMgHw@Red> (raw)
In-Reply-To: <20210726152533.2281139-1-mudongliangabcd@gmail.com>
Le Mon, Jul 26, 2021 at 11:25:21PM +0800, Dongliang Mu a écrit :
> In sun8i_ss_hash_run, all the dma_mmap_sg/single will cause memory leak
> due to no corresponding unmap operation if errors happen.
>
> Fix this by adding error handling part for all the dma_mmap_sg/single.
>
Hello
I have nearly the same comment than on your sun8i-ce patch, (copy result only if err===0 and wording).
Regards
prev parent reply other threads:[~2021-08-02 18:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 15:25 [PATCH v4] crypto: sun8i-ss: fix multiple memory leaks in sun8i_ss_hash_run Dongliang Mu
2021-07-26 15:31 ` Dongliang Mu
2021-08-02 18:27 ` Corentin Labbe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQg4+skrb9dxMgHw@Red \
--to=clabbe.montjoie@gmail.com \
--cc=ardb@kernel.org \
--cc=chenxiang66@hisilicon.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=ebiggers@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=mudongliangabcd@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox