From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id E9285C4338F
	for <linux-kernel@archiver.kernel.org>; Tue,  3 Aug 2021 06:20:46 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id BD22260F94
	for <linux-kernel@archiver.kernel.org>; Tue,  3 Aug 2021 06:20:46 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233919AbhHCGU4 (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Tue, 3 Aug 2021 02:20:56 -0400
Received: from mail.kernel.org ([198.145.29.99]:35782 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S230096AbhHCGUx (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 3 Aug 2021 02:20:53 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id CA86560F9C;
        Tue,  3 Aug 2021 06:20:41 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
        s=korg; t=1627971642;
        bh=KFMCVPIMKcMJnCLKQzmv4zHTkJF8NX258rq+X+2IlNU=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=QHeyNy9c/FoMaBXWIR0Beybldvq2gTmYZ+OU8jX1ir0h4pJ6xbhAN1hp8DLSVdXLP
         aBOBDk+OFrTPQ5fTiD/g6kXnoswV0R/8eaTTsUlAE9k5PgZ+KJMRpBCFdZANEIWDNb
         ScBadz22q2MWE2UmRpkSUW7BCL3ijShCtXiFMa7k=
Date:   Tue, 3 Aug 2021 08:20:39 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
        Larry Finger <Larry.Finger@lwfinger.net>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: r8188eu: core: Change the length of an array
Message-ID: <YQjgN/Xx5LUYtzz0@kroah.com>
References: <20210802203020.9679-1-fmdefrancesco@gmail.com>
 <20210803061441.GK25548@kadam>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210803061441.GK25548@kadam>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 03, 2021 at 09:14:42AM +0300, Dan Carpenter wrote:
> On Mon, Aug 02, 2021 at 10:30:20PM +0200, Fabio M. De Francesco wrote:
> > IPX_NODE_LEN == 6, while addr.f1 should only have 4 elements.
> > Replace IPX_NODE_LEN with 4. In the while, remove the excess spaces
> > before the fields of the union.
> > 
> > Fixes: 56febcc2595e ("staging: r8188eu: Fix different base types in assignments and parameters")
> 
> Ugh...  I really feel we'd be better off reverting that patch entirely.

I do too, let me go revert that...