From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05D9FC4320A for ; Thu, 5 Aug 2021 11:07:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E271161102 for ; Thu, 5 Aug 2021 11:07:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240805AbhHELHs (ORCPT ); Thu, 5 Aug 2021 07:07:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:59192 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240799AbhHELHp (ORCPT ); Thu, 5 Aug 2021 07:07:45 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C8E8061004; Thu, 5 Aug 2021 11:07:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1628161651; bh=ZimSHSr81sxCTYUBZ1LOL41Alcaubv55ZtIbHYn9Yhw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1U0qi+U9pqFAzjgGKwCbEsQTp557pdYeUAVPsLRZ3gUGw4ZQG4+cdC9pVqTcHVKA8 Z8qr4UbicAb3McT5TzBRioQ178yfENkKF1dhi7UNyOOwEd4gKwGX40QKZiJQYJLrTj jZBcGGpdhDHdV7XfSdnxlp6R1mt/OX+ESkbRkUK8= Date: Thu, 5 Aug 2021 13:07:28 +0200 From: Greg Kroah-Hartman To: Martin Kaiser Cc: Larry Finger , Phillip Potter , Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: r8188eu: remove RT_TRACE and DBG_88E prints from usb_intf.c Message-ID: References: <20210801173023.1370-1-martin@kaiser.cx> <20210804141031.12303-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210804141031.12303-1-martin@kaiser.cx> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 04, 2021 at 04:10:31PM +0200, Martin Kaiser wrote: > We should use the standard mechanism for debug prints. Remove the > prints that use driver-specific macros. > > Handle errors from the usb_autopm_get_interface call instead of just > showing a debug print. > > Signed-off-by: Martin Kaiser > --- > v2: > - bring back usb_autopm_get_interface, handle errors This is a v2 of patch 1 in a series? Or something else? When resending a new version, please always send out a whole new series to make it obvious what to do when reviewing them. I've dropped this series, please fix up and resend. thanks, greg k-h