From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9119C4338F for ; Thu, 5 Aug 2021 11:08:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF4E561107 for ; Thu, 5 Aug 2021 11:08:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240817AbhHELI2 (ORCPT ); Thu, 5 Aug 2021 07:08:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:59778 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240738AbhHELIZ (ORCPT ); Thu, 5 Aug 2021 07:08:25 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0377460F22; Thu, 5 Aug 2021 11:08:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1628161691; bh=RnT92SYGhIXN6hiGQaaRNCG7tySLmSwCS/xmeQhHUFg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VgV4jVsdJM70+IBj4940m2mPNjfXTckt4k+3FQufmbq+1RHziKfLwFl1WPBkc2VvD rOLw+BJYv1zMbSVx9FQjgjGHAo1tFn0I2ibyuq74Xv2U+qx7M91W9B26+mIig2YEAP HpfWKSpDqfRi5Mtdk8d8/pTqeC63lKpNae+QSPB8= Date: Thu, 5 Aug 2021 13:08:08 +0200 From: Greg Kroah-Hartman To: Martin Kaiser Cc: Larry Finger , Phillip Potter , Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: r8188eu: remove RT_TRACE and DBG_88E prints from ioctl_linux.c Message-ID: References: <20210802073917.8647-1-martin@kaiser.cx> <20210804141916.13832-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210804141916.13832-1-martin@kaiser.cx> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 04, 2021 at 04:19:16PM +0200, Martin Kaiser wrote: > We should use the standard mechanism for debug prints. Remove the > prints that use driver-specific macros. > > Remove all "IOL tests" from rtw_dbg_port as these tests don't make sense > without a success/fail print at the end. (The rtl8723bs driver removed > the tests as well.) > > Signed-off-by: Martin Kaiser > --- > v2: > - remove IOL tests > > drivers/staging/r8188eu/os_dep/ioctl_linux.c | 851 +------------------ > 1 file changed, 33 insertions(+), 818 deletions(-) Can you add this to the other series you are going to resend so I know what is the latest to review? thanks, greg k-h