From: Lee Jones <lee.jones@linaro.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Chen-Yu Tsai <wens@csie.org>, C++ / GCC <cpp@gcc.lt>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: axp20x: Add supplied-from property to axp288_fuel_gauge cell
Date: Thu, 5 Aug 2021 14:11:32 +0100 [thread overview]
Message-ID: <YQvjhKmGU/HdPmgw@google.com> (raw)
In-Reply-To: <20210717162528.272797-1-hdegoede@redhat.com>
On Sat, 17 Jul 2021, Hans de Goede wrote:
> The power-supply framework has the notion of one power-supply device
> being supplied by another. A typical example of this is a charger
> charging a battery.
>
> A tablet getting plugged in to charge (or plugged out) only results in
> events seen by the axp288_charger device / MFD cell. Which means that
> a change udev-event only gets send for the charger power-supply class
> device, not for the battery (the axp288_fuel_gauge device).
>
> The axp288_fuel_gauge does have an external_power_change'd callback
> which will generate a change udev-event when called. But before this
> commit this never got called because the power-supply core only calls
> this when a power-supply class device's supplier changes and the
> supplier link from axp288_charger to axp288_fuel_gauge was missing.
>
> Add a "supplied-from" property to axp288_fuel_gauge cell, pointing
> to the "axp288_charger" power-supply class device, so that the
> axp288_fuel_gauge's external_power_change'd callback gets called on
> axp288_charger state changes.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/mfd/axp20x.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-08-05 13:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-17 16:25 [PATCH] mfd: axp20x: Add supplied-from property to axp288_fuel_gauge cell Hans de Goede
2021-07-18 3:51 ` Chen-Yu Tsai
2021-07-19 10:48 ` Lee Jones
2021-07-27 19:24 ` Hans de Goede
2021-08-05 13:11 ` Lee Jones [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-07-05 20:52 Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQvjhKmGU/HdPmgw@google.com \
--to=lee.jones@linaro.org \
--cc=cpp@gcc.lt \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox