From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E7B2C4338F for ; Thu, 5 Aug 2021 13:24:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 825AB610CD for ; Thu, 5 Aug 2021 13:24:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240799AbhHENYs (ORCPT ); Thu, 5 Aug 2021 09:24:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240596AbhHENYo (ORCPT ); Thu, 5 Aug 2021 09:24:44 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A457DC061765 for ; Thu, 5 Aug 2021 06:24:29 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id n12-20020a05600c3b8cb029025a67bbd40aso6354457wms.0 for ; Thu, 05 Aug 2021 06:24:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Iqn99+NR+zmd9KKhJkQyCbBLw0GflZl6gBOww2IROEQ=; b=bntZ2ge6fBCva5wnFEiLi5KkcQnPrlapFhdlIYdpi/zryYWMl4JhyLt4t7jkgBoVyJ B99NN/s3Q3UpswilsW3N4F060uJGrJMPSOn+S0vGEESblbHZZ2ajFXghVNgNgZBXg4jD SHIxseSBoWquPW2FRcy9BKCWnlVUamaQvPuUM4tPmpaKAgSxeUuIadTIfOLw8JiSLOfb bCvSWkovYRsL6tBhAMKfPkZ68t+0ICdxuXlfSanQspDj80gi1WVOv4kCR8DxxashcJ3p JgYS3ns0cQcOCme3Pbm0/1PHopbtMYxWb9h1Y0WgR5n1Zb7L3MgX9cF2Y7STCCeKHg3W FsNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Iqn99+NR+zmd9KKhJkQyCbBLw0GflZl6gBOww2IROEQ=; b=JwyRnMlv/MGjINpv3AMgQPmbAV+19gYaTFkGFJlbTRUGRLvOTkgP/9UxyaLvqb7dvO J/NiW7omNFC0hWLwc/uWWmNzA5z4SsvMCJqI4KqnKE9FK49aiezpMNmYdu55mXR3dfUr hEJtIpINfIxdQewA6iOIY1OkCPkIGyz1K70ATeeZjg7HMJICP+JlDF4KzwJtopqUk53Q DXxD86CcemA6oHcYnTVLUSULfuU5eD1GsXKoZ4T0J2fs73gXvGHxQNccoyvtLLdav2n5 ETlG1T4bCELICgDqAfxD1x/wi+bmjA15BhjOMc8t9j0cthSxFIGFYDY4OHCrZIhv6B4P GjCg== X-Gm-Message-State: AOAM531R3AUpOx+QO1NGABYBIhVnjOUZ2m1lsuUmaKoDmzQN3FfHc9Fs 09k5FLr28RXE6FOYR14AA+hoEA== X-Google-Smtp-Source: ABdhPJwVUzR98VEgjB92sUkpVKaZ4Ofz1p2L3XASJNWwWEJZvLn12PanJY/w/oxqhpQc2OzbpJQsUg== X-Received: by 2002:a1c:6a08:: with SMTP id f8mr4844376wmc.19.1628169868307; Thu, 05 Aug 2021 06:24:28 -0700 (PDT) Received: from google.com ([109.180.115.228]) by smtp.gmail.com with ESMTPSA id q17sm6203876wre.3.2021.08.05.06.24.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Aug 2021 06:24:27 -0700 (PDT) Date: Thu, 5 Aug 2021 14:24:26 +0100 From: Lee Jones To: Linus Walleij Cc: linux-kernel@vger.kernel.org, "Rafael J . Wysocki" , Daniel Lezcano , linux-pm@vger.kernel.org Subject: Re: [PATCH] mfd/cpuidle: ux500: Rename driver symbol Message-ID: References: <20210802090859.3237509-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210802090859.3237509-1-linus.walleij@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 02 Aug 2021, Linus Walleij wrote: > The PRCMU driver defines this as a DT node but there are no bindings > for it and it needs no data from the device tree. Just spawn the > device directly in the same way as the watchdog. > > Name it "db8500-cpuidle" since there are no ambitions to support any > more SoCs than this one. > > This rids this annoying boot message: > [ 0.032610] cpuidle-dbx500: Failed to locate of_node [id: 0] > > However I think the device still spawns and work just fine, despite > not finding a device tree node. > > Cc: Rafael J. Wysocki > Cc: Daniel Lezcano > Cc: linux-pm@vger.kernel.org > Signed-off-by: Linus Walleij > --- > Rafael/Daniel: it would be perfect if one of you could ACK > this so that Lee can just merge this into the MFD tree as > a non-urgent fix. > --- > drivers/cpuidle/cpuidle-ux500.c | 2 +- > drivers/mfd/db8500-prcmu.c | 6 ++++-- > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/cpuidle/cpuidle-ux500.c b/drivers/cpuidle/cpuidle-ux500.c > index a2d34be17a09..f7d778580e9b 100644 > --- a/drivers/cpuidle/cpuidle-ux500.c > +++ b/drivers/cpuidle/cpuidle-ux500.c > @@ -117,7 +117,7 @@ static int dbx500_cpuidle_probe(struct platform_device *pdev) > > static struct platform_driver dbx500_cpuidle_plat_driver = { > .driver = { > - .name = "cpuidle-dbx500", > + .name = "db8500-cpuidle", > }, > .probe = dbx500_cpuidle_probe, > }; > diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c > index 75049cf38832..64dd4f9a1e49 100644 > --- a/drivers/mfd/db8500-prcmu.c > +++ b/drivers/mfd/db8500-prcmu.c > @@ -2951,14 +2951,16 @@ static const struct mfd_cell common_prcmu_devs[] = { > .pdata_size = sizeof(db8500_wdt_pdata), > .id = -1, > }, > + { > + .name = "db8500-cpuidle", > + .id = -1, > + }, > }; > > static const struct mfd_cell db8500_prcmu_devs[] = { > MFD_CELL_OF("db8500-prcmu-regulators", NULL, > &db8500_regulators, sizeof(db8500_regulators), 0, > "stericsson,db8500-prcmu-regulator"), > - MFD_CELL_OF("cpuidle-dbx500", > - NULL, NULL, 0, 0, "stericsson,cpuidle-dbx500"), Probably neater (with less semantic changes) if you just used: MFD_CELL_NAME() > MFD_CELL_OF("db8500-thermal", > NULL, NULL, 0, 0, "stericsson,db8500-thermal"), > }; -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog