From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40615C432BE for ; Wed, 18 Aug 2021 14:40:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B12D610CB for ; Wed, 18 Aug 2021 14:40:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239216AbhHROkm (ORCPT ); Wed, 18 Aug 2021 10:40:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:41720 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238113AbhHROkl (ORCPT ); Wed, 18 Aug 2021 10:40:41 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CC59D610CF; Wed, 18 Aug 2021 14:40:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1629297606; bh=GcDcn1p5bbIe0j3lDftYK1lLYju/eoi4yW4XncUjXv8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WV9iTYVHIy8ObTfgjZwgmSFVzNaBVwypYgC5gh6MKpUVJc1vnnvmU1A8K84BlIMdg HLnE1fN48lexq+wubKlTbc6zwFq94eIzQBeCUxzP5gionxsaQylGI+7s9Ixs+8q3uT JWrWnvA6Hy/GEXhJjMS79QJjndU1xfuK4LCSwVIY= Date: Wed, 18 Aug 2021 16:40:03 +0200 From: Greg Kroah-Hartman To: Icenowy Zheng Cc: Heikki Krogerus , Guenter Roeck , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: typec: tcpm: always rediscover when swapping DR Message-ID: References: <20210813043131.833006-1-icenowy@aosc.io> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 18, 2021 at 10:02:24PM +0800, Icenowy Zheng wrote: > > > 于 2021年8月18日 GMT+08:00 下午9:56:38, Greg Kroah-Hartman 写到: > >On Tue, Aug 17, 2021 at 02:00:33PM +0300, Heikki Krogerus wrote: > >> > >Why is it necessary to do discovery with data role swap in general? > >> > > >> > I think it could be possible for devices to expose different altmode > >> > with different role. > >> > >> OK. FWIW: > >> > >> Acked-by: Heikki Krogerus > > > >Is this conflicting with https://lore.kernel.org/r/20210816075449.2236547-1-kyletso@google.com ? > > > >Which of these two should I take, both? Neither? > > Don't take this, it's against spec. Ok, now dropped. What about the linked patch above? Does that work for you instead? thanks, greg k-h