From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dongliang Mu <mudongliangabcd@gmail.com>
Cc: Samuel Iglesias Gonsalvez <siglesias@igalia.com>,
Jens Taprogge <jens.taprogge@taprogge.org>,
Lv Yunlong <lyl2019@mail.ustc.edu.cn>,
Randy Dunlap <rdunlap@infradead.org>,
Aditya Srivastava <yashsri421@gmail.com>,
industrypack-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] ipack: tpci200: fix many double free issues in tpci200_pci_probe
Date: Tue, 10 Aug 2021 11:53:54 +0200 [thread overview]
Message-ID: <YRJMssKBFeToLvKi@kroah.com> (raw)
In-Reply-To: <20210810074932.3934499-1-mudongliangabcd@gmail.com>
On Tue, Aug 10, 2021 at 03:49:21PM +0800, Dongliang Mu wrote:
> The function tpci200_register called by tpci200_install and
> tpci200_unregister called by tpci200_uninstall are in pair. However,
> tpci200_unregister has some cleanup operations not in the
> tpci200_register. So the error handling code of tpci200_pci_probe has
> many different double free issues.
>
> Fix this problem by moving those cleanup operations out of
> tpci200_unregister, into tpci200_pci_remove and reverting
> the previous commit 9272e5d0028d ("ipack/carriers/tpci200:
> Fix a double free in tpci200_pci_probe").
>
> Reported-by: Dongliang Mu <mudongliangabcd@gmail.com>
> Fixes: 9272e5d0028d ("ipack/carriers/tpci200: Fix a double free in tpci200_pci_probe")
> Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
> ---
No cc: stable markings on the patches?
:(
next prev parent reply other threads:[~2021-08-10 9:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 7:49 [PATCH v3 1/2] ipack: tpci200: fix many double free issues in tpci200_pci_probe Dongliang Mu
2021-08-10 7:49 ` [PATCH v3 2/2] ipack: tpci200: fix memory leak in the tpci200_register Dongliang Mu
2021-08-10 9:53 ` Greg Kroah-Hartman [this message]
2021-08-10 10:05 ` [PATCH v3 1/2] ipack: tpci200: fix many double free issues in tpci200_pci_probe Dongliang Mu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRJMssKBFeToLvKi@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=industrypack-devel@lists.sourceforge.net \
--cc=jens.taprogge@taprogge.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyl2019@mail.ustc.edu.cn \
--cc=mudongliangabcd@gmail.com \
--cc=rdunlap@infradead.org \
--cc=siglesias@igalia.com \
--cc=yashsri421@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox