From: Greg KH <gregkh@linuxfoundation.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: phil@philpotter.co.uk, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: Remove some dead files
Date: Tue, 10 Aug 2021 12:19:01 +0200 [thread overview]
Message-ID: <YRJSlU9jquQkseXt@kroah.com> (raw)
In-Reply-To: <20210809210912.1022-1-Larry.Finger@lwfinger.net>
On Mon, Aug 09, 2021 at 04:09:12PM -0500, Larry Finger wrote:
> The porting of the new version included 3 source files that are
> only used for testing of the device. They are not needed here.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
> drivers/staging/r8188eu/Makefile | 3 -
> drivers/staging/r8188eu/core/rtw_mp.c | 974 ---------------
> drivers/staging/r8188eu/core/rtw_mp_ioctl.c | 1170 -------------------
> drivers/staging/r8188eu/hal/rtl8188e_mp.c | 798 -------------
> 4 files changed, 2945 deletions(-)
> delete mode 100644 drivers/staging/r8188eu/core/rtw_mp.c
> delete mode 100644 drivers/staging/r8188eu/core/rtw_mp_ioctl.c
> delete mode 100644 drivers/staging/r8188eu/hal/rtl8188e_mp.c
I get the following error with this patch applied:
ERROR: modpost: "rtl8188eu_oid_rt_pro_set_data_rate_hdl" [drivers/staging/r8188eu/r8188eu.ko] undefined!
ERROR: modpost: "rtl8188eu_oid_rt_pro_set_single_carrier_tx_hdl" [drivers/staging/r8188eu/r8188eu.ko] undefined!
ERROR: modpost: "rtl8188eu_oid_rt_pro_stop_test_hdl" [drivers/staging/r8188eu/r8188eu.ko] undefined!
ERROR: modpost: "mp_stop_test" [drivers/staging/r8188eu/r8188eu.ko] undefined!
ERROR: modpost: "MPT_InitializeAdapter" [drivers/staging/r8188eu/r8188eu.ko] undefined!
ERROR: modpost: "Hal_GetThermalMeter" [drivers/staging/r8188eu/r8188eu.ko] undefined!
ERROR: modpost: "Hal_SetThermalMeter" [drivers/staging/r8188eu/r8188eu.ko] undefined!
ERROR: modpost: "MP_PHY_SetRFPathSwitch" [drivers/staging/r8188eu/r8188eu.ko] undefined!
ERROR: modpost: "rtl8188eu_oid_rt_get_efuse_max_size_hdl" [drivers/staging/r8188eu/r8188eu.ko] undefined!
ERROR: modpost: "rtl8188eu_oid_rt_pro_trigger_gpio_hdl" [drivers/staging/r8188eu/r8188eu.ko] undefined!
WARNING: modpost: suppressed 46 unresolved symbol warnings because there were too many)
Are you sure those symbols are not used?
thanks,
greg k-h
prev parent reply other threads:[~2021-08-10 10:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 21:09 [PATCH] staging: r8188eu: Remove some dead files Larry Finger
2021-08-10 10:19 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRJSlU9jquQkseXt@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox