Re: [PATCH 09/20] Move Intel SCU IPC of pdx86 to intel directory to increase readability.

Andy Shevchenko
2021-08-10T13:27:49Z

On Tue, Aug 10, 2021 at 07:43:42PM +0800, Kate Hsuan wrote:
> Hi Mika,
>
> Thanks for your suggestion.
> I'll add them to the patches and resend them again.
>
> Thank you.

Please, do not top post!

> On Tue, Aug 10, 2021 at 6:06 PM Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> >
> > Hi,
> >
> > No objections, I think this is good idea but..
> >
> > On Tue, Aug 10, 2021 at 05:58:21PM +0800, Kate Hsuan wrote:
> >
> > .. I suggest to add proper commit message here. Many maintainers ignore
> > patches that don't have one.

> > > rename drivers/platform/x86/{ => intel/scu}/intel_scu_ipc.c (100%)
> > > rename drivers/platform/x86/{ => intel/scu}/intel_scu_ipcutil.c (100%)
> > > rename drivers/platform/x86/{ => intel/scu}/intel_scu_pcidrv.c (100%)
> > > rename drivers/platform/x86/{ => intel/scu}/intel_scu_pltdrv.c (100%)
> > > rename drivers/platform/x86/{ => intel/scu}/intel_scu_wdt.c (100%)

Besides what Mika said this should follow the example of pmt, like dropping the
intel_scu prefix from the files, but leave it for the module (see Makefile
tricks for the details how to achieve this).

--
With Best Regards,
Andy Shevchenko