From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BE4FC43216 for ; Fri, 13 Aug 2021 13:46:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 480AE60232 for ; Fri, 13 Aug 2021 13:46:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240729AbhHMNqh (ORCPT ); Fri, 13 Aug 2021 09:46:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:46448 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240660AbhHMNqY (ORCPT ); Fri, 13 Aug 2021 09:46:24 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 243CE610FA; Fri, 13 Aug 2021 13:45:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628862357; bh=mEgbN/2TUygqQhXGsMw6TNwBF+MK1gURp246MiNT6Xk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nsCOy4l26L1yFd3FhXOQYaE+184kPfg96L+XUF9Z6rgCGBidjmLSJ6i8UTNz0m5vm PZZVvrGMNwlaakGTE3sddzi+l4Ey9fWNK2V9zyzpZI5CC84Wn88Vojhm1uvaQnBAt9 0hTvlEK/3Qf8cOF4z4m5CoZrrnlXz9xsDWfOjd/tEzg+XFCQnY400ZkEKxq1AGv1ma mS+8cJs4zsOcofPcC/97FK/JWrxyxabtaPrI9/eY1qdBSpK3UbXFkjBsqMfVIKuFZd rFU4WCnQ98jovFNK6Wu2nPkKTzr7y5SwjGZddBFhWzQbR9zfnliF371w66oevNgPRl Pn3hzI8SMJmkw== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 67835403F2; Fri, 13 Aug 2021 10:45:54 -0300 (-03) Date: Fri, 13 Aug 2021 10:45:54 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Namhyung Kim , Jiri Olsa , Ingo Molnar , Peter Zijlstra , LKML , Andi Kleen , Alexei Budankov , James Clark , Thomas Richter Subject: Re: [PATCH] perf test: Do not compare overheads in the zstd comp test Message-ID: References: <20210812235738.1684583-1-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Aug 12, 2021 at 05:09:20PM -0700, Ian Rogers escreveu: > On Thu, Aug 12, 2021 at 4:57 PM Namhyung Kim wrote: > > > > The overhead can vary on each run so it'd make the test failed > > sometimes. Also order of hist entry can change. > > > > Use perf report -F option to omit the overhead field and sort the > > result alphabetically. > > > > Signed-off-by: Namhyung Kim > > Acked-by: Ian Rogers Thanks, applied. - Arnaldo > Thanks, > Ian > > > --- > > tools/perf/tests/shell/record+zstd_comp_decomp.sh | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/tools/perf/tests/shell/record+zstd_comp_decomp.sh b/tools/perf/tests/shell/record+zstd_comp_decomp.sh > > index 045723b3d992..8a168cf8bacc 100755 > > --- a/tools/perf/tests/shell/record+zstd_comp_decomp.sh > > +++ b/tools/perf/tests/shell/record+zstd_comp_decomp.sh > > @@ -25,8 +25,8 @@ check_compressed_stats() { > > > > check_compressed_output() { > > $perf_tool inject -i $trace_file -o $trace_file.decomp && > > - $perf_tool report -i $trace_file --stdio | head -n -3 > $trace_file.comp.output && > > - $perf_tool report -i $trace_file.decomp --stdio | head -n -3 > $trace_file.decomp.output && > > + $perf_tool report -i $trace_file --stdio -F comm,dso,sym | head -n -3 > $trace_file.comp.output && > > + $perf_tool report -i $trace_file.decomp --stdio -F comm,dso,sym | head -n -3 > $trace_file.decomp.output && > > diff $trace_file.comp.output $trace_file.decomp.output > > } > > > > -- > > 2.33.0.rc1.237.g0d66db33f3-goog > > -- - Arnaldo