* [PATCH] perf test: Do not compare overheads in the zstd comp test
@ 2021-08-12 23:57 Namhyung Kim
2021-08-13 0:09 ` Ian Rogers
0 siblings, 1 reply; 3+ messages in thread
From: Namhyung Kim @ 2021-08-12 23:57 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo, Jiri Olsa
Cc: Ingo Molnar, Peter Zijlstra, LKML, Andi Kleen, Ian Rogers,
Alexei Budankov, James Clark, Thomas Richter
The overhead can vary on each run so it'd make the test failed
sometimes. Also order of hist entry can change.
Use perf report -F option to omit the overhead field and sort the
result alphabetically.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/tests/shell/record+zstd_comp_decomp.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/tests/shell/record+zstd_comp_decomp.sh b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
index 045723b3d992..8a168cf8bacc 100755
--- a/tools/perf/tests/shell/record+zstd_comp_decomp.sh
+++ b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
@@ -25,8 +25,8 @@ check_compressed_stats() {
check_compressed_output() {
$perf_tool inject -i $trace_file -o $trace_file.decomp &&
- $perf_tool report -i $trace_file --stdio | head -n -3 > $trace_file.comp.output &&
- $perf_tool report -i $trace_file.decomp --stdio | head -n -3 > $trace_file.decomp.output &&
+ $perf_tool report -i $trace_file --stdio -F comm,dso,sym | head -n -3 > $trace_file.comp.output &&
+ $perf_tool report -i $trace_file.decomp --stdio -F comm,dso,sym | head -n -3 > $trace_file.decomp.output &&
diff $trace_file.comp.output $trace_file.decomp.output
}
--
2.33.0.rc1.237.g0d66db33f3-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] perf test: Do not compare overheads in the zstd comp test
2021-08-12 23:57 [PATCH] perf test: Do not compare overheads in the zstd comp test Namhyung Kim
@ 2021-08-13 0:09 ` Ian Rogers
2021-08-13 13:45 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: Ian Rogers @ 2021-08-13 0:09 UTC (permalink / raw)
To: Namhyung Kim
Cc: Arnaldo Carvalho de Melo, Jiri Olsa, Ingo Molnar, Peter Zijlstra,
LKML, Andi Kleen, Alexei Budankov, James Clark, Thomas Richter
On Thu, Aug 12, 2021 at 4:57 PM Namhyung Kim <namhyung@kernel.org> wrote:
>
> The overhead can vary on each run so it'd make the test failed
> sometimes. Also order of hist entry can change.
>
> Use perf report -F option to omit the overhead field and sort the
> result alphabetically.
>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Ian Rogers <irogers@google.com>
Thanks,
Ian
> ---
> tools/perf/tests/shell/record+zstd_comp_decomp.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/tests/shell/record+zstd_comp_decomp.sh b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
> index 045723b3d992..8a168cf8bacc 100755
> --- a/tools/perf/tests/shell/record+zstd_comp_decomp.sh
> +++ b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
> @@ -25,8 +25,8 @@ check_compressed_stats() {
>
> check_compressed_output() {
> $perf_tool inject -i $trace_file -o $trace_file.decomp &&
> - $perf_tool report -i $trace_file --stdio | head -n -3 > $trace_file.comp.output &&
> - $perf_tool report -i $trace_file.decomp --stdio | head -n -3 > $trace_file.decomp.output &&
> + $perf_tool report -i $trace_file --stdio -F comm,dso,sym | head -n -3 > $trace_file.comp.output &&
> + $perf_tool report -i $trace_file.decomp --stdio -F comm,dso,sym | head -n -3 > $trace_file.decomp.output &&
> diff $trace_file.comp.output $trace_file.decomp.output
> }
>
> --
> 2.33.0.rc1.237.g0d66db33f3-goog
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] perf test: Do not compare overheads in the zstd comp test
2021-08-13 0:09 ` Ian Rogers
@ 2021-08-13 13:45 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2021-08-13 13:45 UTC (permalink / raw)
To: Ian Rogers
Cc: Namhyung Kim, Jiri Olsa, Ingo Molnar, Peter Zijlstra, LKML,
Andi Kleen, Alexei Budankov, James Clark, Thomas Richter
Em Thu, Aug 12, 2021 at 05:09:20PM -0700, Ian Rogers escreveu:
> On Thu, Aug 12, 2021 at 4:57 PM Namhyung Kim <namhyung@kernel.org> wrote:
> >
> > The overhead can vary on each run so it'd make the test failed
> > sometimes. Also order of hist entry can change.
> >
> > Use perf report -F option to omit the overhead field and sort the
> > result alphabetically.
> >
> > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
>
> Acked-by: Ian Rogers <irogers@google.com>
Thanks, applied.
- Arnaldo
> Thanks,
> Ian
>
> > ---
> > tools/perf/tests/shell/record+zstd_comp_decomp.sh | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/perf/tests/shell/record+zstd_comp_decomp.sh b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
> > index 045723b3d992..8a168cf8bacc 100755
> > --- a/tools/perf/tests/shell/record+zstd_comp_decomp.sh
> > +++ b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
> > @@ -25,8 +25,8 @@ check_compressed_stats() {
> >
> > check_compressed_output() {
> > $perf_tool inject -i $trace_file -o $trace_file.decomp &&
> > - $perf_tool report -i $trace_file --stdio | head -n -3 > $trace_file.comp.output &&
> > - $perf_tool report -i $trace_file.decomp --stdio | head -n -3 > $trace_file.decomp.output &&
> > + $perf_tool report -i $trace_file --stdio -F comm,dso,sym | head -n -3 > $trace_file.comp.output &&
> > + $perf_tool report -i $trace_file.decomp --stdio -F comm,dso,sym | head -n -3 > $trace_file.decomp.output &&
> > diff $trace_file.comp.output $trace_file.decomp.output
> > }
> >
> > --
> > 2.33.0.rc1.237.g0d66db33f3-goog
> >
--
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-13 13:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-12 23:57 [PATCH] perf test: Do not compare overheads in the zstd comp test Namhyung Kim
2021-08-13 0:09 ` Ian Rogers
2021-08-13 13:45 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox