From: Greg KH <gregkh@linuxfoundation.org>
To: Barry Song <21cnbao@gmail.com>
Cc: bhelgaas@google.com, corbet@lwn.net,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
mchehab+huawei@kernel.org, Jonathan.Cameron@huawei.com,
leon@kernel.org, schnelle@linux.ibm.com, bilbao@vt.edu,
luzmaximilian@gmail.com, linuxarm@huawei.com,
Barry Song <song.bao.hua@hisilicon.com>
Subject: Re: [PATCH] PCI/MSI: Clarify the irq sysfs ABI for PCI devices
Date: Sat, 14 Aug 2021 10:24:50 +0200 [thread overview]
Message-ID: <YRd90p6Kcxpq6cbp@kroah.com> (raw)
In-Reply-To: <20210813122650.25764-1-21cnbao@gmail.com>
On Sat, Aug 14, 2021 at 12:26:50AM +1200, Barry Song wrote:
> From: Barry Song <song.bao.hua@hisilicon.com>
>
> /sys/bus/pci/devices/.../irq has been there for many years but it has never
> been documented. This patch is trying to document it. Plus, irq ABI is very
> confusing at this moment especially for MSI and MSI-x cases. MSI sets irq
> to the first number in the vector, but MSI-X does nothing for this though
> it saves default_irq in msix_setup_entries(). Weird the saved default_irq
> for MSI-X is never used in pci_msix_shutdown(), which is quite different
> with pci_msi_shutdown(). Thus, this patch also moves to show the first IRQ
> number which is from the first msi_entry for MSI-X. Hopefully, this can
> make irq ABI more clear and more consistent.
>
> Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
> ---
> Documentation/ABI/testing/sysfs-bus-pci | 8 ++++++++
> drivers/pci/msi.c | 6 ++++++
> 2 files changed, 14 insertions(+)
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2021-08-14 8:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 12:26 [PATCH] PCI/MSI: Clarify the irq sysfs ABI for PCI devices Barry Song
2021-08-14 8:24 ` Greg KH [this message]
2021-08-20 21:43 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRd90p6Kcxpq6cbp@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=21cnbao@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=bhelgaas@google.com \
--cc=bilbao@vt.edu \
--cc=corbet@lwn.net \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=luzmaximilian@gmail.com \
--cc=mchehab+huawei@kernel.org \
--cc=schnelle@linux.ibm.com \
--cc=song.bao.hua@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox