Re: [RESEND PATCH V3] genirq/affinity: add helper of irq_affinity_calc_sets

Ming Lei
2021-08-14T11:35:33Z

On Fri, Aug 06, 2021 at 04:19:37PM +0800, Ming Lei wrote:
> When driver requests to allocate irq affinity managed vectors,
> pci_alloc_irq_vectors_affinity() may fallback to single vector
> allocation. In this situation, we don't need to call
> irq_create_affinity_masks for calling into ->calc_sets() for
> avoiding potential memory leak, so add the helper for this purpose.
>
> Fixes: c66d4bd110a1 ("genirq/affinity: Add new callback for (re)calculating interrupt sets")
> Reported-by: Bjorn Helgaas <helgaas@kernel.org>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: linux-pci@vger.kernel.org
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
> V3:
> - avoid pointless negations
> V2:
> - move WARN_ON_ONCE() into irq_affinity_calc_sets
> - don't install default calc_sets() callback as suggested by
> Christoph

Hello Thomas,

Can you take a look at this patch?

Thanks,
Ming