From: Leon Romanovsky <leon@kernel.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Russell King - ARM Linux admin <linux@armlinux.org.uk>,
Joe Perches <joe@perches.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Andy Whitcroft <apw@canonical.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Julia Lawall <julia.lawall@inria.fr>
Subject: Re: [PATCH] checkpatch: prefer = {} initializations to = {0}
Date: Sat, 14 Aug 2021 18:52:57 +0300 [thread overview]
Message-ID: <YRfm2RRYla7Nemsj@unreal> (raw)
In-Reply-To: <YRfZwrJUutB4IO+G@zeniv-ca.linux.org.uk>
On Sat, Aug 14, 2021 at 02:57:06PM +0000, Al Viro wrote:
> On Sat, Aug 14, 2021 at 05:38:27PM +0300, Leon Romanovsky wrote:
>
> > There are number of reasons why you didn't notice any difference.
> > 1. {} is GCC extension
> > 2. {} was adopted in latest C standards, so need to check which one GCC 10
> > is using by default.
> > 3. Main difference will be in padding - {0} will set to zero fields but
> > won't touch padding, while {} will zero everything.
>
> References on (3), please?
I reread gcc/c/c-typeck.c and at lest for GCC 10, I'm wrong about padding.
Sorry about that.
8630 struct c_expr
8631 pop_init_level (location_t loc, int implicit,
8632 struct obstack *braced_init_obstack,
8633 location_t insert_before)
....
8692 switch (vec_safe_length (constructor_elements))
8693 {
8694 case 0:
8695 /* Initialization with { } counts as zeroinit. */
8696 constructor_zeroinit = 1;
8697 break;
8698 case 1:
8699 /* This might be zeroinit as well. */
8700 if (integer_zerop ((*constructor_elements)[0].value))
8701 constructor_zeroinit = 1;
8702 break;
8703 default:
8704 /* If the constructor has more than one element, it can't be { 0 }. */
8705 constructor_zeroinit = 0;
8706 break;
8707 }
8708
next prev parent reply other threads:[~2021-08-14 15:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 10:43 [PATCH] checkpatch: prefer = {} initializations to = {0} Dan Carpenter
2021-08-05 12:27 ` Joe Perches
2021-08-05 18:04 ` Joe Perches
2021-08-05 18:17 ` Julia Lawall
2021-08-05 18:28 ` Joe Perches
2021-08-05 18:44 ` Julia Lawall
2021-08-14 13:59 ` Christophe JAILLET
2021-08-14 13:59 ` Christophe JAILLET
2021-08-14 14:05 ` Marion & Christophe JAILLET
2021-08-14 14:38 ` Leon Romanovsky
2021-08-14 14:57 ` Al Viro
2021-08-14 15:52 ` Leon Romanovsky [this message]
2021-08-14 16:45 ` Al Viro
2021-08-14 14:44 ` Russell King (Oracle)
2021-08-14 14:52 ` Al Viro
2021-08-14 20:20 ` Christophe JAILLET
2021-08-16 6:55 ` Dan Carpenter
2021-08-16 7:23 ` Russell King (Oracle)
2021-08-16 19:05 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRfm2RRYla7Nemsj@unreal \
--to=leon@kernel.org \
--cc=apw@canonical.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dan.carpenter@oracle.com \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=julia.lawall@inria.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukas.bulwahn@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox