Re: [PATCH 0/2] rtc: pch-rtc: add Intel Series PCH built-in read-only RTC

Alexandre Belloni
2021-08-14T23:22:21Z

On 15/08/2021 01:42:15+0300, Paul Fertser wrote:
> On Tue, Aug 10, 2021 at 06:44:34PM +0300, Ivan Mikhaylov wrote:
> > Add RTC driver with dt binding tree document. Also this driver adds one sysfs
> > attribute for host power control which I think is odd for RTC driver.
> > Need I cut it off and use I2C_SLAVE_FORCE? I2C_SLAVE_FORCE is not good
> > way too from my point of view. Is there any better approach?
>
> Reading the C620 datasheet I see this interface also allows other
> commands (wake up, watchdog feeding, reboot etc.) and reading statuses
> (e.g Intruder Detect, POWER_OK_BAD).
>
> I think if there's any plan to use anything other but RTC via this
> interface then the driver should be registered as an MFD.
>

This is not the current thinking, if everything is integrated, then
there is no issue registering a watchdog from the RTC driver. I'll let
you check with Lee...

However, I'm not sure what is the correct interface for poweroff/reboot
control.

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering