Re: [PATCH 7/7] blk-mq: build default queue map via group_cpus_evenly()

kernel test robot
2021-08-14T16:32:20Z

[-- Attachment #1: Type: text/plain, Size: 4259 bytes --]

Hi Ming,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/irq/core]
[also build test ERROR on next-20210813]
[cannot apply to block/for-next linux/master linus/master v5.14-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Ming-Lei/genirq-affinity-abstract-new-API-from-managed-irq-affinity-spread/20210814-203741
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 04c2721d3530f0723b4c922a8fa9f26b202a20de
config: arc-randconfig-r043-20210814 (attached as .config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/46b1d0ed609db266f6f18e7156c4f294bf6c4502
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Ming-Lei/genirq-affinity-abstract-new-API-from-managed-irq-affinity-spread/20210814-203741
git checkout 46b1d0ed609db266f6f18e7156c4f294bf6c4502
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arc

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

In file included from block/blk-mq-cpumap.c:13:
include/linux/group_cpus.h: In function 'group_cpus_evenly':
>> include/linux/group_cpus.h:17:33: error: implicit declaration of function 'kcalloc'; did you mean 'kvcalloc'? [-Werror=implicit-function-declaration]
17 | struct cpumask *masks = kcalloc(numgrps, sizeof(*masks), GFP_KERNEL);
| ^~~~~~~
| kvcalloc
>> include/linux/group_cpus.h:17:33: warning: initialization of 'struct cpumask *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
In file included from include/linux/genhd.h:16,
from include/linux/blkdev.h:8,
from include/linux/blk-mq.h:5,
from block/blk-mq-cpumap.c:15:
include/linux/slab.h: At top level:
>> include/linux/slab.h:658:21: error: conflicting types for 'kcalloc'; have 'void *(size_t, size_t, gfp_t)' {aka 'void *(unsigned int, unsigned int, unsigned int)'}
658 | static inline void *kcalloc(size_t n, size_t size, gfp_t flags)
| ^~~~~~~
In file included from block/blk-mq-cpumap.c:13:
include/linux/group_cpus.h:17:33: note: previous implicit declaration of 'kcalloc' with type 'int()'
17 | struct cpumask *masks = kcalloc(numgrps, sizeof(*masks), GFP_KERNEL);
| ^~~~~~~
cc1: some warnings being treated as errors

vim +17 include/linux/group_cpus.h

759f72186bfdd5 Ming Lei 2021-08-14 11
5cd330f089b089 Ming Lei 2021-08-14 12 #ifdef CONFIG_SMP
759f72186bfdd5 Ming Lei 2021-08-14 13 struct cpumask *group_cpus_evenly(unsigned int numgrps);
5cd330f089b089 Ming Lei 2021-08-14 14 #else
5cd330f089b089 Ming Lei 2021-08-14 15 static inline struct cpumask *group_cpus_evenly(unsigned int numgrps)
5cd330f089b089 Ming Lei 2021-08-14 16 {
5cd330f089b089 Ming Lei 2021-08-14 @17 struct cpumask *masks = kcalloc(numgrps, sizeof(*masks), GFP_KERNEL);
5cd330f089b089 Ming Lei 2021-08-14 18
5cd330f089b089 Ming Lei 2021-08-14 19 if (!masks)
5cd330f089b089 Ming Lei 2021-08-14 20 return NULL;
5cd330f089b089 Ming Lei 2021-08-14 21
5cd330f089b089 Ming Lei 2021-08-14 22 /* assign all CPUs(cpu 0) to the 1st group only */
5cd330f089b089 Ming Lei 2021-08-14 23 cpumask_copy(&masks[0], cpu_possible_mask);
5cd330f089b089 Ming Lei 2021-08-14 24 return masks;
5cd330f089b089 Ming Lei 2021-08-14 25 }
5cd330f089b089 Ming Lei 2021-08-14 26 #endif
759f72186bfdd5 Ming Lei 2021-08-14 27

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34173 bytes --]