Re: [PATCH v2 6/8] dt-bindings: clock: samsung: convert Exynos AudSS to dtschema

Rob Herring
2021-08-17T20:25:26Z

On Wed, Aug 11, 2021 at 08:46:46AM +0200, Krzysztof Kozlowski wrote:
> On 10/08/2021 19:46, Sam Protsenko wrote:
> > On Tue, 10 Aug 2021 at 12:32, Krzysztof Kozlowski
> > <krzysztof.kozlowski@canonical.com> wrote:
> >>
> >> Convert Samsung Exynos Audio SubSystem clock controller bindings to DT
> >> schema format using json-schema.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> >> ---
> >> .../bindings/clock/clk-exynos-audss.txt | 103 ------------------
> >> .../clock/samsung,exynos-audss-clock.yaml | 79 ++++++++++++++
> >> 2 files changed, 79 insertions(+), 103 deletions(-)
> >> delete mode 100644 Documentation/devicetree/bindings/clock/clk-exynos-audss.txt
> >> create mode 100644 Documentation/devicetree/bindings/clock/samsung,exynos-audss-clock.yaml
> >>
> >> diff --git a/Documentation/devicetree/bindings/clock/clk-exynos-audss.txt b/Documentation/devicetree/bindings/clock/clk-exynos-audss.txt
> >> deleted file mode 100644
> >> index 6030afb10b5c..000000000000
> >> --- a/Documentation/devicetree/bindings/clock/clk-exynos-audss.txt
> >> +++ /dev/null
> >> @@ -1,103 +0,0 @@
> >> -* Samsung Audio Subsystem Clock Controller
> >> -
> >> -The Samsung Audio Subsystem clock controller generates and supplies clocks
> >> -to Audio Subsystem block available in the S5PV210 and Exynos SoCs. The clock
> >> -binding described here is applicable to all SoCs in Exynos family.
> >> -
> >> -Required Properties:
> >> -
> >> -- compatible: should be one of the following:
> >> - - "samsung,exynos4210-audss-clock" - controller compatible with all Exynos4 SoCs.
> >> - - "samsung,exynos5250-audss-clock" - controller compatible with Exynos5250
> >> - SoCs.
> >> - - "samsung,exynos5410-audss-clock" - controller compatible with Exynos5410
> >> - SoCs.
> >> - - "samsung,exynos5420-audss-clock" - controller compatible with Exynos5420
> >> - SoCs.
> >> -- reg: physical base address and length of the controller's register set.
> >> -
> >> -- #clock-cells: should be 1.
> >> -
> >> -- clocks:
> >> - - pll_ref: Fixed rate PLL reference clock, parent of mout_audss. "fin_pll"
> >> - is used if not specified.
> >> - - pll_in: Input PLL to the AudioSS block, parent of mout_audss. "fout_epll"
> >> - is used if not specified.
> >> - - cdclk: External i2s clock, parent of mout_i2s. "cdclk0" is used if not
> >> - specified.
> >> - - sclk_audio: Audio bus clock, parent of mout_i2s. "sclk_audio0" is used if
> >> - not specified.
> >> - - sclk_pcm_in: PCM clock, parent of sclk_pcm. "sclk_pcm0" is used if not
> >> - specified.
> >> -
> >> -- clock-names: Aliases for the above clocks. They should be "pll_ref",
> >> - "pll_in", "cdclk", "sclk_audio", and "sclk_pcm_in" respectively.
> >> -
> >> -Optional Properties:
> >> -
> >> - - power-domains: a phandle to respective power domain node as described by
> >> - generic PM domain bindings (see power/power_domain.txt for more
> >> - information).
> >> -
> >> -The following is the list of clocks generated by the controller. Each clock is
> >> -assigned an identifier and client nodes use this identifier to specify the
> >> -clock which they consume. Some of the clocks are available only on a particular
> >> -Exynos4 SoC and this is specified where applicable.
> >> -
> >> -Provided clocks:
> >> -
> >> -Clock ID SoC (if specific)
> >> ------------------------------------------------
> >> -
> >> -mout_audss 0
> >> -mout_i2s 1
> >> -dout_srp 2
> >> -dout_aud_bus 3
> >> -dout_i2s 4
> >> -srp_clk 5
> >> -i2s_bus 6
> >> -sclk_i2s 7
> >> -pcm_bus 8
> >> -sclk_pcm 9
> >> -adma 10 Exynos5420
> >> -
> >> -Example 1: An example of a clock controller node using the default input
> >> - clock names is listed below.
> >> -
> >> -clock_audss: audss-clock-controller@3810000 {
> >> - compatible = "samsung,exynos5250-audss-clock";
> >> - reg = <0x03810000 0x0C>;
> >> - #clock-cells = <1>;
> >> -};
> >> -
> >> -Example 2: An example of a clock controller node with the input clocks
> >> - specified.
> >> -
> >> -clock_audss: audss-clock-controller@3810000 {
> >> - compatible = "samsung,exynos5250-audss-clock";
> >> - reg = <0x03810000 0x0C>;
> >> - #clock-cells = <1>;
> >> - clocks = <&clock 1>, <&clock 7>, <&clock 138>, <&clock 160>,
> >> - <&ext_i2s_clk>;
> >> - clock-names = "pll_ref", "pll_in", "sclk_audio", "sclk_pcm_in", "cdclk";
> >> -};
> >> -
> >> -Example 3: I2S controller node that consumes the clock generated by the clock
> >> - controller. Refer to the standard clock bindings for information
> >> - about 'clocks' and 'clock-names' property.
> >> -
> >> -i2s0: i2s@3830000 {
> >> - compatible = "samsung,i2s-v5";
> >> - reg = <0x03830000 0x100>;
> >> - dmas = <&pdma0 10
> >> - &pdma0 9
> >> - &pdma0 8>;
> >> - dma-names = "tx", "rx", "tx-sec";
> >> - clocks = <&clock_audss EXYNOS_I2S_BUS>,
> >> - <&clock_audss EXYNOS_I2S_BUS>,
> >> - <&clock_audss EXYNOS_SCLK_I2S>,
> >> - <&clock_audss EXYNOS_MOUT_AUDSS>,
> >> - <&clock_audss EXYNOS_MOUT_I2S>;
> >> - clock-names = "iis", "i2s_opclk0", "i2s_opclk1",
> >> - "mout_audss", "mout_i2s";
> >> -};
> >
> > Seems like some examples and "Provided clocks" table were dropped in
> > in yaml binding. Also there is no description for example present in
> > yaml file. Is that some redundant info and was dropped intentionally?
> > I'm just worrying about losing some useful info during the conversion.
>
> I don't see any point of having a clock consumer example in a clock
> provider binding.

+1

Just another one to get wrong...