From: Greg KH <greg@kroah.com>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: dan.carpenter@oracle.com, yangyingliang@huawei.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: r8188eu: Remove unused including <linux/version.h>
Date: Wed, 18 Aug 2021 08:43:58 +0200 [thread overview]
Message-ID: <YRysLl5Yu/ngNOl3@kroah.com> (raw)
In-Reply-To: <20210818063653.2851-1-caihuoqing@baidu.com>
On Wed, Aug 18, 2021 at 02:36:53PM +0800, Cai Huoqing wrote:
> Remove including <linux/version.h> that don't need it
>
> v1->v2: remove "based on staging-next" from commit message
> v2->v3: add changelog to commit message
As the documentation states, these lines need to go below the --- line,
right?
Please fix up and send a v4.
thanks,
greg k-h
prev parent reply other threads:[~2021-08-18 6:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 6:36 [PATCH v3] staging: r8188eu: Remove unused including <linux/version.h> Cai Huoqing
2021-08-18 6:40 ` Michael Straube
2021-08-18 6:43 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRysLl5Yu/ngNOl3@kroah.com \
--to=greg@kroah.com \
--cc=caihuoqing@baidu.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox