From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC3ECC432BE for ; Mon, 30 Aug 2021 18:54:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 96B7760F8F for ; Mon, 30 Aug 2021 18:54:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232733AbhH3Szl (ORCPT ); Mon, 30 Aug 2021 14:55:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:57832 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230455AbhH3Szj (ORCPT ); Mon, 30 Aug 2021 14:55:39 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 243F660F3A; Mon, 30 Aug 2021 18:54:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630349685; bh=7HzKsqTjhf9cL7OnqXmeucrSOEnIfz78gL52j0Ig89k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hGpq/lPWxlUZvQsqUiBWK/3gUFY0sBUAJdnEVMyM6F5pdB74FE8+S7GRIvD5nEr9E j7LflIh+CKnI6pFy6b+l37l90GVEZWV79BnctKvW5nGjCsDTVuLa51o5cv55BptoUR PUCTV3XlFf2u2QA0209HK16CJnLf7blH/F1Cn+1A/LfgUaf0fp+6sOCFT95ZamaCxU RxRblNYeMc/AxAIIlCigAhXZ6DPx/By+psyygdTtEbVevjEnFeJIX4AHH8hJqBhYqq XSucJMe1GWGQb/ZTSQ+yJ+JtzAs0pu/U32hy6AYhKfqlTpEmsWQFy5AQqSw9BwBPx3 W9y8BcuoBhQNA== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id DACCB4007E; Mon, 30 Aug 2021 15:54:42 -0300 (-03) Date: Mon, 30 Aug 2021 15:54:42 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Namhyung Kim , Jiri Olsa , Ingo Molnar , Peter Zijlstra , LKML , Andi Kleen , Adrian Hunter , Stephane Eranian Subject: Re: [PATCH] perf record: Fix wrong comm in system-wide mode with delay Message-ID: References: <20210827233212.3121037-1-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Aug 30, 2021 at 10:33:16AM -0700, Ian Rogers escreveu: > On Fri, Aug 27, 2021 at 4:32 PM Namhyung Kim wrote: > > Stephane found that the name of the forked process in a system-wide > > mode is wrong when --delay option is used. For example, > > > > # perf record -a --delay=1000 noploop 3 > > > > The noploop process will run a busy loop for 3 second. And on an idle > > machine it should show up at the top in the perf report. It works > > well without the --delay option. But if I add the option, it showed > > 'perf' not 'noploop'. > > > > # perf report -s comm -q | head -3 > > 52.94% perf > > 16.65% swapper > > 12.04% chrome > > > > It turned out that the dummy event didn't work at all and it missed > > COMM and MMAP events for the noploop process (and others too). We > > should enable the dummy event immediately in system-wide mode, as the > > enable-on-exec would work only for task events. > > > > With this change, > > > > # perf report -s comm -q | head -3 > > 52.75% noploop > > 17.03% swapper > > 12.83% chrome > > > > Cc: Adrian Hunter > > Reported-by: Stephane Eranian > > Signed-off-by: Namhyung Kim > > Acked-by: Ian Rogers Thanks, applied. - Arnaldo