From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A26CC4320A for ; Mon, 30 Aug 2021 23:25:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6095A60FC0 for ; Mon, 30 Aug 2021 23:25:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239050AbhH3X0H (ORCPT ); Mon, 30 Aug 2021 19:26:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232049AbhH3X0D (ORCPT ); Mon, 30 Aug 2021 19:26:03 -0400 Received: from mail-ot1-x330.google.com (mail-ot1-x330.google.com [IPv6:2607:f8b0:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83422C061575 for ; Mon, 30 Aug 2021 16:25:09 -0700 (PDT) Received: by mail-ot1-x330.google.com with SMTP id o16-20020a9d2210000000b0051b1e56c98fso20521949ota.8 for ; Mon, 30 Aug 2021 16:25:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=w4/IsuVv9oo3M3aKM3cA3InZRtIzixTG8bEPAEfnTls=; b=c5B+huAXwVCck8wf85wSYwP3k+wUjlYIcoCcEH9p3HWqTCpdXt4hGFC+qnNJc+dPsm nZ/WJKxAOMQ3Fe7E4U68Y2h0JFyYfVcK9cX6LLphOW8xkwIOxTu5NdtGbInbk1wcsr5e uzkhS5J8gu9Eq1TP43kE1/IlkpU+zVhpC3ntwL7js8/CcU/dk2O84BCWQa7d6Q7FDuUx D1rZI4seCX0fUqDR9ZFhGeFoxXiUY901U51wMJWgma/lYzIkIcugBQE9oopLSo/6edSq mNnX9qVlMO5bllSQE4+3ykjUPAjQlEREbAaZFa9jca2zeybIzdprHJC4Q2i6gHFWlgvq 7haw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=w4/IsuVv9oo3M3aKM3cA3InZRtIzixTG8bEPAEfnTls=; b=Am2+i85wgQyQ4YGD9pDdzp0yoZBTBRbIWUFYZfUQJ4OKqylBN5o0li2cWKBfKhQzEt 7kgmwEexSqqVmqBazdRn1CSrT7q7a7ftrFO8P3SGQmizkqcladDdziMiJDF4LXHnmLCN d3RjpcErkJ6OCSs4WGKCwIGGncxLvXKZVeo9ozx0rnEKFdMeX7nNCyah5OGNMXlo+YKQ VSQjciscYTqrFQI+2+bhCXBbPdosew3wbHhcg9TS/zyanY4R0Al24Pzrdv4epeOKBZnp G2wj/36N0RDPK6k89ffZ2piRghBD96xmsJENpq210y5pf2fRXNQ/epexTq4UPZZx1bPL 443Q== X-Gm-Message-State: AOAM531ml0E949gndSp/O1Xvq9pzbyNSDP9+3oDBWMOSB5txCknivbaX q1jJqbuKQSSGz8kMwobc6BGC74P+CH7CRw== X-Google-Smtp-Source: ABdhPJxsDMoje5wLuQQ9Kp7DnKAzCEWWc6pFAa7nBJRiedJC/ShJFR+WOdDp6ztjI8hjPxVOhWAR7w== X-Received: by 2002:a05:6830:1056:: with SMTP id b22mr21759892otp.325.1630365908859; Mon, 30 Aug 2021 16:25:08 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id v24sm3543993ote.66.2021.08.30.16.25.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Aug 2021 16:25:08 -0700 (PDT) Date: Mon, 30 Aug 2021 18:25:06 -0500 From: Bjorn Andersson To: Deepak Kumar Singh Cc: swboyd@chromium.org, clew@codeaurora.org, sibis@codeaurora.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, Andy Gross Subject: Re: [PATCH V7 1/2] soc: qcom: aoss: Expose send for generic usecase Message-ID: References: <1630323451-7160-1-git-send-email-deesin@codeaurora.org> <1630323451-7160-2-git-send-email-deesin@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1630323451-7160-2-git-send-email-deesin@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 30 Aug 06:37 CDT 2021, Deepak Kumar Singh wrote: > Not all upcoming usecases will have an interface to allow the aoss > driver to hook onto. Expose the send api and create a get function to > enable drivers to send their own messages to aoss. > > Signed-off-by: Chris Lew > Signed-off-by: Deepak Kumar Singh > Reviewed-by: Stephen Boyd > --- > drivers/soc/qcom/qcom_aoss.c | 54 +++++++++++++++++++++++++++++++++++++- > include/linux/soc/qcom/qcom_aoss.h | 38 +++++++++++++++++++++++++++ > 2 files changed, 91 insertions(+), 1 deletion(-) > create mode 100644 include/linux/soc/qcom/qcom_aoss.h > > diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c > index 934fcc4..bf0a6280 100644 > --- a/drivers/soc/qcom/qcom_aoss.c > +++ b/drivers/soc/qcom/qcom_aoss.c > @@ -8,10 +8,12 @@ > #include > #include > #include > +#include > #include > #include > #include > #include > +#include > > #define QMP_DESC_MAGIC 0x0 > #define QMP_DESC_VERSION 0x4 > @@ -223,11 +225,14 @@ static bool qmp_message_empty(struct qmp *qmp) > * > * Return: 0 on success, negative errno on failure > */ > -static int qmp_send(struct qmp *qmp, const void *data, size_t len) > +int qmp_send(struct qmp *qmp, const void *data, size_t len) > { > long time_left; > int ret; > > + if (WARN_ON(IS_ERR_OR_NULL(qmp) || !data)) > + return -EINVAL; > + > if (WARN_ON(len + sizeof(u32) > qmp->size)) > return -EINVAL; > > @@ -261,6 +266,7 @@ static int qmp_send(struct qmp *qmp, const void *data, size_t len) > > return ret; > } > +EXPORT_SYMBOL(qmp_send); > > static int qmp_qdss_clk_prepare(struct clk_hw *hw) > { > @@ -515,6 +521,51 @@ static void qmp_cooling_devices_remove(struct qmp *qmp) > thermal_cooling_device_unregister(qmp->cooling_devs[i].cdev); > } > > +/** > + * qmp_get() - get a qmp handle from a device > + * @dev: client device pointer > + * > + * Return: handle to qmp device on success, ERR_PTR() on failure > + */ > +struct qmp *qmp_get(struct device *dev) > +{ > + struct platform_device *pdev; > + struct device_node *np; > + struct qmp *qmp; > + > + if (!dev || !dev->of_node) > + return ERR_PTR(-EINVAL); > + > + np = of_parse_phandle(dev->of_node, "qcom,qmp", 0); > + if (!np) > + return ERR_PTR(-ENODEV); > + > + pdev = of_find_device_by_node(np); > + of_node_put(np); > + if (!pdev) > + return ERR_PTR(-EINVAL); > + > + qmp = platform_get_drvdata(pdev); > + > + return qmp ? qmp : ERR_PTR(-EPROBE_DEFER); > +} > +EXPORT_SYMBOL(qmp_get); > + > +/** > + * qmp_put() - release a qmp handle > + * @qmp: qmp handle obtained from qmp_get() > + */ > +void qmp_put(struct qmp *qmp) > +{ > + if (!IS_ERR_OR_NULL(qmp)) > + put_device(qmp->dev); > + /* > + * Match get_device() inside of_find_device_by_node() in > + * qmp_get() > + */ Afaict this comment relates to the put_device() above, which typically would imply that the comment should be above or inside the if statement? > +} > +EXPORT_SYMBOL(qmp_put); > + Regards, Bjorn > static int qmp_probe(struct platform_device *pdev) > { > struct resource *res; > @@ -610,6 +661,7 @@ static struct platform_driver qmp_driver = { > .driver = { > .name = "qcom_aoss_qmp", > .of_match_table = qmp_dt_match, > + .suppress_bind_attrs = true, > }, > .probe = qmp_probe, > .remove = qmp_remove, > diff --git a/include/linux/soc/qcom/qcom_aoss.h b/include/linux/soc/qcom/qcom_aoss.h > new file mode 100644 > index 0000000..3c2a82e > --- /dev/null > +++ b/include/linux/soc/qcom/qcom_aoss.h > @@ -0,0 +1,38 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * Copyright (c) 2021, The Linux Foundation. All rights reserved. > + */ > + > +#ifndef __QCOM_AOSS_H__ > +#define __QCOM_AOSS_H__ > + > +#include > +#include > + > +struct qmp; > + > +#if IS_ENABLED(CONFIG_QCOM_AOSS_QMP) > + > +int qmp_send(struct qmp *qmp, const void *data, size_t len); > +struct qmp *qmp_get(struct device *dev); > +void qmp_put(struct qmp *qmp); > + > +#else > + > +static inline int qmp_send(struct qmp *qmp, const void *data, size_t len) > +{ > + return -ENODEV; > +} > + > +static inline struct qmp *qmp_get(struct device *dev) > +{ > + return ERR_PTR(-ENODEV); > +} > + > +static inline void qmp_put(struct qmp *qmp) > +{ > +} > + > +#endif > + > +#endif > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >