From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 306CFC432BE for ; Tue, 31 Aug 2021 23:05:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1678660200 for ; Tue, 31 Aug 2021 23:05:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241355AbhHaXGJ (ORCPT ); Tue, 31 Aug 2021 19:06:09 -0400 Received: from rosenzweig.io ([138.197.143.207]:44874 "EHLO rosenzweig.io" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241192AbhHaXGG (ORCPT ); Tue, 31 Aug 2021 19:06:06 -0400 Date: Tue, 31 Aug 2021 17:40:32 -0400 From: Alyssa Rosenzweig To: Sven Peter Cc: iommu@lists.linux-foundation.org, Joerg Roedel , Will Deacon , Robin Murphy , Arnd Bergmann , Mohamed Mediouni , Alexander Graf , Hector Martin , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 8/8] iommu/dart: Remove force_bypass logic Message-ID: References: <20210828153642.19396-1-sven@svenpeter.dev> <20210828153642.19396-9-sven@svenpeter.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210828153642.19396-9-sven@svenpeter.dev> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Now that the dma-iommu API supports IOMMU granules which are larger than > the CPU page size and that the kernel no longer runs into a BUG_ON when > devices are attached to a domain with such a granule there's no need to > force bypass mode anymore. > > Signed-off-by: Sven Peter > --- > drivers/iommu/apple-dart.c | 14 ++------------ > 1 file changed, 2 insertions(+), 12 deletions(-) This was such an ugly hack, glad to see it go. This patch is Reviewed-by: Alyssa Rosenzweig