From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: gustavo.pimentel@synopsys.com, vkoul@kernel.org,
vireshk@kernel.org, wangzhou1@hisilicon.com, logang@deltatee.com,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] dmaengine: switch from 'pci_' to 'dma_' API
Date: Mon, 23 Aug 2021 10:29:17 +0300 [thread overview]
Message-ID: <YSNOTX68ltbt2hwf@smile.fi.intel.com> (raw)
In-Reply-To: <547fae4abef1ca3bf2198ca68e6c361b4d02f13c.1629635852.git.christophe.jaillet@wanadoo.fr>
On Sun, Aug 22, 2021 at 02:40:22PM +0200, Christophe JAILLET wrote:
> The wrappers in include/linux/pci-dma-compat.h should go away.
>
> The patch has been generated with the coccinelle script below.
>
> It has been hand modified to use 'dma_set_mask_and_coherent()' instead of
> 'pci_set_dma_mask()/pci_set_consistent_dma_mask()' when applicable.
> This is less verbose.
>
> It has been compile tested.
> @@
> expression e1, e2;
> @@
> - pci_set_consistent_dma_mask(e1, e2)
> + dma_set_coherent_mask(&e1->dev, e2)
Can we, please, replace this long noise in the commit message with a link to a
script in coccinelle data base?
And the same comment for any future submission that are based on the scripts
(esp. coccinelle ones).
...
> This patch is mostly mechanical and compile tested. I hope it is ok to
> update the "drivers/dma/" directory all at once.
There is another discussion with Hellwig [1] about 64-bit DMA mask,
i.e. it doesn't fail anymore, so you need to rework drivers accordingly.
[1]: https://lkml.org/lkml/2021/6/7/398
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-08-23 7:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-22 12:40 [PATCH] dmaengine: switch from 'pci_' to 'dma_' API Christophe JAILLET
2021-08-23 7:29 ` Andy Shevchenko [this message]
2021-08-23 19:26 ` Christophe JAILLET
2021-08-23 19:47 ` Julia Lawall
2021-08-23 21:11 ` Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSNOTX68ltbt2hwf@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dmaengine@vger.kernel.org \
--cc=gustavo.pimentel@synopsys.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=vireshk@kernel.org \
--cc=vkoul@kernel.org \
--cc=wangzhou1@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox