From: Matthew Wilcox <willy@infradead.org>
To: Tawah Peggy <tawahpeggy98@gmail.com>
Cc: Kroah-Hartman <greg@kroah.com>,
outreachy-kernel@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [Outreachy kernel] [PATCH] [Outreachy Kernel] Staging: wlan-ng: cfg80211: Fix Lines should not end with a '('
Date: Tue, 24 Aug 2021 10:49:18 +0100 [thread overview]
Message-ID: <YSTAnuoGF4zuAFrg@casper.infradead.org> (raw)
In-Reply-To: <20210824031551.GA80985@peggy-InsydeH2O-EFI-BIOS>
On Tue, Aug 24, 2021 at 04:15:51AM +0100, Tawah Peggy wrote:
> - ieee80211_frequency_to_channel(
> - request->channels[i]->center_freq);
> + ieee80211_frequency_to_channel
> + (request->channels[i]->center_freq);
This is the wrong way to fix this warning. Function names should not be
divorced from their arguments.
next prev parent reply other threads:[~2021-08-24 9:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 3:15 [PATCH] [Outreachy Kernel] Staging: wlan-ng: cfg80211: Fix Lines should not end with a '(' Tawah Peggy
2021-08-24 9:49 ` Matthew Wilcox [this message]
[not found] ` <CADT-=4mWmUmBQtwwdRXUCPZfePbX6gQB_+ZrVwuE-GC=TYE2rw@mail.gmail.com>
2021-08-31 20:12 ` [Outreachy kernel] " Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSTAnuoGF4zuAFrg@casper.infradead.org \
--to=willy@infradead.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=tawahpeggy98@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox