Re: [PATCH 2/3] libperf tests: Fix verbose printing

Rob Herring
2021-08-23T20:26:51Z

On Fri, Aug 20, 2021 at 06:39:07PM +0900, Shunsuke Nakamura wrote:
> libperf's verbose printing checks the -v option every time the macro _T_ START

__T_START

> is called.
>
> Since there are currently four libperf tests registered, the macro _T_ START is
> called four times, but verbose printing after the second time is not output.
>
> Resets the index of the element processed by getopt() and fix verbose printing
> so that it prints in all tests.
>
> Signed-off-by: Shunsuke Nakamura <nakamura.shun@fujitsu.com>
> ---
> tools/lib/perf/include/internal/tests.h | 2 ++
> 1 file changed, 2 insertions(+)

Acked-by: Rob Herring <robh@kernel.org>

>
> diff --git a/tools/lib/perf/include/internal/tests.h b/tools/lib/perf/include/internal/tests.h
> index 61052099225b..b130a6663ff8 100644
> --- a/tools/lib/perf/include/internal/tests.h
> +++ b/tools/lib/perf/include/internal/tests.h
> @@ -23,6 +23,8 @@ static inline int get_verbose(char **argv, int argc)
> break;
> }
> }
> + optind = 1;
> +
> return verbose;
> }
>
> --
> 2.25.1
>
>