From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4610C432BE for ; Tue, 24 Aug 2021 18:37:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C6AFE61212 for ; Tue, 24 Aug 2021 18:37:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233981AbhHXSia (ORCPT ); Tue, 24 Aug 2021 14:38:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233688AbhHXSi3 (ORCPT ); Tue, 24 Aug 2021 14:38:29 -0400 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0038C061757 for ; Tue, 24 Aug 2021 11:37:44 -0700 (PDT) Received: by mail-pj1-x102c.google.com with SMTP id mq3so14818426pjb.5 for ; Tue, 24 Aug 2021 11:37:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tv/nPc8c3b2qEEOTOUCkzBCA/UiZaoRBnN+t+aCQOu4=; b=NKUmxzcATIKvEt/jjhKnjVZN2Cfmdjm8h5j/1Lq/MhWpLUmgL0Bkf+gpFWP6l6+1f2 q9PADEOVGFuBGZ8YcqmJRxYaIiahEmsY6ObaxXyltz1dBlYDnteopN0uN12HO7i3mHzF R+XG9lmLbjGy1/LPQjpHEg9wUTDnkX16Jispg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tv/nPc8c3b2qEEOTOUCkzBCA/UiZaoRBnN+t+aCQOu4=; b=LBUt/1bKZc1tlBurA3DiIIl9F4T+QrmZJGnJ9QKEzMJurrFIPD810rMFCJhDGrdAcf OOY9iej26gid8+nwvstUgn/tRuMSqoPM3iz1Tb5AjID5tgqsaVItOfmv+b19tOapeuD1 d8C3b6qduxVFoO3vqfRhRlKMRvC4vOKvh5w084qyY2a+9IHfYvaWNpHFeO5/4D9bl0Xg 1skBYhlAey8ukAiciX+ZmoK+ntBnbzlE5ZmYP9pHxnycl2rmgTwA385SGB1VKFt5Miak fkwJghl9NEW+qurX3ScpGUCwT/ZvzCcIM7vaaCrh4yAtx3Rl22BEmK6iJ2YK4bxM72I6 itQQ== X-Gm-Message-State: AOAM532WFksYxTv73kRNhjWqjGqBz0UI5xlYJJjG5hf4JQawXYhrSSr1 J/l0xsVVkX5i5JhXVfcVQsfoEQ== X-Google-Smtp-Source: ABdhPJzTmCLJO0i02apqzlEk3S7QLFHlA5GXZgG4/wXfDOzlCYW6C29KqFcaYGzh7WDyP99s9zWX/w== X-Received: by 2002:a17:902:b190:b029:12d:487:dddc with SMTP id s16-20020a170902b190b029012d0487dddcmr5054694plr.24.1629830264572; Tue, 24 Aug 2021 11:37:44 -0700 (PDT) Received: from localhost ([2620:15c:202:201:7e28:476b:8ddf:c945]) by smtp.gmail.com with UTF8SMTPSA id y19sm19393870pfr.137.2021.08.24.11.37.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Aug 2021 11:37:44 -0700 (PDT) Date: Tue, 24 Aug 2021 11:37:42 -0700 From: Matthias Kaehlcke To: Stephen Boyd Cc: Amit Kucheria , Andy Gross , Bjorn Andersson , Daniel Lezcano , Dmitry Baryshkov , Thara Gopinath , Zhang Rui , linux-pm@vger.kernel.org, Douglas Anderson , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] thermal: qcom: spmi-adc-tm5: Don't abort probing if a sensor is not used Message-ID: References: <20210823134726.1.I1dd23ddf77e5b3568625d80d6827653af071ce19@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 23, 2021 at 06:50:04PM -0500, Stephen Boyd wrote: > Quoting Matthias Kaehlcke (2021-08-23 13:47:30) > > adc_tm5_register_tzd() registers the thermal zone sensors for all > > channels of the thermal monitor. If the registration of one channel > > fails the function skips the processing of the remaining channels > > and returns an error, which results in _probe() being aborted. > > > > One of the reasons the registration could fail is that none of the > > thermal zones is using the channel/sensor, which hardly is a critical > > error (if it is an error at all). If this case is detected emit a > > warning and continue with processing the remaining channels. > > > > Fixes: ca66dca5eda6 ("thermal: qcom: add support for adc-tm5 PMIC thermal monitor") > > Signed-off-by: Matthias Kaehlcke > > --- > > Reported-by: Stephen Boyd > Reviewed-by: Stephen Boyd Thanks for the review! > Should we also disable the 'charger-thermistor@0' node in > sc7180-trogdor.dtsi on lazor boards, instead of the thermal zone, or in > addition to the thermal zone? It isn't used so there's not much value in > exposing it. I wouldn't do it instead of disabling the thermal zone, a TZ without a sensor doesn't seem very useful. IIUC the thermistor nodes would need to be deleted, not disabled. Currently the nodes don't have labels, so either the labels would need to be added, or the deletion would have to look something like this: &pm6150_adc { /delete-node/ charger-thermistor@4f; }; &pm6150_adc_tm { /delete-node/ charger-thermistor@0; }; If the change is done for Lazor it should also be done for PomPom and CoachZ. I don't see a strong need to delete the ADC nodes with the clutter it adds, but I'm open to it if you prefer :)