Re: [PATCH v5 08/12] x86/tdx: Add HLT support for TDX guest

Andi Kleen
2021-08-24T18:28:37Z

>> It would be helpful to use local variables to document what's up, e.g.
>>
>>       const bool irqs_enabled = true;
>>     const bool do_sti = true;
>>
>>     ret = _tdx_hypercall(EXIT_REASON_HLT, irqs_enabled0, 0, 0,
>> do_sti, NULL);
>
> Ok. I can follow your suggestion in next submission.

I would use defines for the argument values, then it's self documenting.

-Andi