Re: [PATCH v5 04/12] x86/tdx: Add protected guest support for TDX guest

Kuppuswamy, Sathyanarayanan
2021-08-20T17:11:30Z

On 8/20/21 9:59 AM, Borislav Petkov wrote:
> Err, why?
>
> TDX is Intel technology. That's like asking to have
>
> sev_prot_guest_has() and amd_prot_guest_has() on AMD.
>
> Maybe I still don't get what you're trying to achieve but from where I'm
> standing that sounds wrong.

My intention was to keep intel_* function clean and hide all TDX specific
customization in tdx_* function (within in tdx.c) and call it from
intel_* function (within cpu/intel.c).

But I understand your point as well. I am fine with moving TDX specific checks to
intel_* function.

--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer